From: Theodore Tso <tytso@mit.edu>
To: Eric Sandeen <sandeen@redhat.com>
Cc: Dan Carpenter <error27@gmail.com>,
adilger@sun.com, linux-ext4@vger.kernel.org
Subject: Re: locking typo in ext4_mb_add_n_trim()
Date: Fri, 27 Mar 2009 19:36:34 -0400 [thread overview]
Message-ID: <20090327233634.GI5176@mit.edu> (raw)
In-Reply-To: <49CCDFDB.9000109@redhat.com>
On Fri, Mar 27, 2009 at 09:16:59AM -0500, Eric Sandeen wrote:
>
> although I wonder why we don't trip over this in spinlock debugging
> (seems like it'd lead to a double unlock at times) I wonder if we can
> tie this to any other bugs we've seen.
I was wondering if it could be tied to the "rm -rf" soft lockup hang....
I wonder if vendor kernels (specifically, Ubuntu in this case) disable
spinlock debugging, which is why we wouldn't have seen the double
unlock warning. (Or maybe it happened earlier in the log, and users
didn't notice it).
- Ted
next prev parent reply other threads:[~2009-03-27 23:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-27 10:27 locking typo in ext4_mb_add_n_trim() Dan Carpenter
2009-03-27 14:16 ` Eric Sandeen
2009-03-27 23:36 ` Theodore Tso [this message]
2009-03-31 13:00 ` Jan Kara
2009-03-27 16:35 ` Aneesh Kumar K.V
2009-03-27 23:20 ` Theodore Tso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090327233634.GI5176@mit.edu \
--to=tytso@mit.edu \
--cc=adilger@sun.com \
--cc=error27@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).