linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andreas Dilger <adilger@sun.com>
To: Michael Rubin <mrubin@google.com>
Cc: Curt Wohlgemuth <curtw@google.com>, linux-ext4@vger.kernel.org
Subject: Re: Use of kmalloc vs vmalloc in ext4?
Date: Mon, 06 Apr 2009 03:33:10 -0600	[thread overview]
Message-ID: <20090406093310.GJ3199@webber.adilger.int> (raw)
In-Reply-To: <532480950904052345m48bc5df5wcdc4c5e32778130c@mail.gmail.com>

On Apr 05, 2009  23:45 -0700, Michael Rubin wrote:
> Anyone have any comments? Or historical reasons? We operate with some
> constrained memory situations, and were wondering if a patch to move
> from kmalloc to vmalloc would be well received.

On 32-bit machines vmalloc space is tiny, and in all cases vmalloc
performance sucks, so traditionally very little kernel allocation
is done with vmalloc.  For one-off allocations like per-fs it is
probably OK to change them to vmalloc.

> On Wed, Mar 11, 2009 at 7:32 AM, Curt Wohlgemuth <curtw@google.com> wrote:
> > I've been running various tests of ext4 partitions lately, and have
> > found that with very low memory situations, I'm getting intermittent
> > mount failures due to ENOMEM from ext4_mb_init() and
> > ext4_fill_flex_info() .  Here's a typical dmesg from the latter:
> >
> >          EXT4-fs: not enough memory for 8198 flex groups
> >          EXT4-fs: unable to initialize flex_bg meta info!
> >
> > This is from a kzalloc() call of size ~64k .  I think the
> > ext4_mb_init() calls to kmalloc() and alloc_percpu() are even smaller.
> >
> > I was wondering why all the code in ext4 (and ext[23], for that
> > matter) uses kmalloc() and friends instead of vmalloc(), at least
> > where it's safe; is it just for performance reasons?
> >
> > I've seen the above errors when I do a mount -a, causing several
> > partitions to be mounted; I can usually mount the failed ones by hand
> > right afterwards, but this is a big difference for us, in our
> > environment, compared to, say, ext2 partitions.
> >
> > Thanks,
> > Curt
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> >
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Cheers, Andreas
--
Andreas Dilger
Sr. Staff Engineer, Lustre Group
Sun Microsystems of Canada, Inc.

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2009-04-06  9:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-11 14:32 Use of kmalloc vs vmalloc in ext4? Curt Wohlgemuth
2009-04-06  6:45 ` Michael Rubin
2009-04-06  9:33   ` Andreas Dilger [this message]
2009-04-25  3:00   ` [PATCH] ext4: Fallback to vmalloc if kmalloc can't allocate s_flex_groups array Theodore Ts'o
2009-04-25  3:28     ` Eric Sandeen
2009-04-25  3:57       ` Theodore Tso
2009-04-25  3:07   ` Use of kmalloc vs vmalloc in ext4? Theodore Tso
2009-04-25  3:39     ` Theodore Tso
2009-04-26  2:12       ` Theodore Tso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090406093310.GJ3199@webber.adilger.int \
    --to=adilger@sun.com \
    --cc=curtw@google.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=mrubin@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).