From: Andreas Dilger <adilger@sun.com>
To: Christian Kujau <lists@nerdbynature.de>
Cc: ext-users <ext3-users@redhat.com>, linux-ext4@vger.kernel.org
Subject: Re: external journal lost [PATCH]
Date: Wed, 08 Apr 2009 22:31:21 -0600 [thread overview]
Message-ID: <20090409043121.GR17302@webber.adilger.int> (raw)
In-Reply-To: <alpine.DEB.2.01.0904080135360.6162@bogon.housecafe.de>
On Apr 08, 2009 01:40 -0700, Christian Kujau wrote:
> On Thu, 2 Apr 2009, Christian Kujau wrote:
> > Hm, I never had to forcefully remove a journal (yet), but from reading the
> > manpage I'd indeed expect to get this removed even if the filesystem is in
> > error. The attached patch to e2fsprogs (latest git) makes tune2fs removing
> > the journal when "-f" is supplied. And it seems to work so far:
> >
> > http://nerdbynature.de/bits/tune2fs/
> >
> > Comments?
>
> Hm, I was really hoping someone would comment on this, as I'm a) puzzled
> as well, why the -force option does not work as expected and b) if this is
> the right thing to do:
Proabably the right thing to do.
> --- e2fsprogs-git/misc/tune2fs.c.ORIG 2009-04-02 22:40:58.740218188 +0200
> +++ e2fsprogs-git/misc/tune2fs.c 2009-04-02 22:42:37.221830335 +0200
> @@ -374,8 +374,8 @@ static void update_feature_set(ext2_fils
> "read-only.\n"), stderr);
> exit(1);
> }
> - if (sb->s_feature_incompat &
> - EXT3_FEATURE_INCOMPAT_RECOVER) {
> + if ((sb->s_feature_incompat &
> + EXT3_FEATURE_INCOMPAT_RECOVER) && (!f_flag)) {
> fputs(_("The needs_recovery flag is set. "
> "Please run e2fsck before clearing\n"
> "the has_journal flag.\n"), stderr);
>
> --
> Bruce Schneier knows the secret formula for Coca-Cola.
>
> _______________________________________________
> Ext3-users mailing list
> Ext3-users@redhat.com
> https://www.redhat.com/mailman/listinfo/ext3-users
Cheers, Andreas
--
Andreas Dilger
Sr. Staff Engineer, Lustre Group
Sun Microsystems of Canada, Inc.
parent reply other threads:[~2009-04-09 4:31 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <alpine.DEB.2.01.0904080135360.6162@bogon.housecafe.de>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090409043121.GR17302@webber.adilger.int \
--to=adilger@sun.com \
--cc=ext3-users@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=lists@nerdbynature.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).