Re: [PATCH] ext2: fix missing mutex_unlock in error path

Jan Kara
2009-04-14T07:43:58Z

Hello,

On Tue 14-04-09 16:36:31, Akinobu Mita wrote:
> Add missing mutex_unlock in error path in ext2_quota_write()
>
> Cc: Jan Kara <jack@suse.cz>
> Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
> ---
> diff --git a/fs/ext2/super.c b/fs/ext2/super.c
> index f983225..5c4afe6 100644
> --- a/fs/ext2/super.c
> +++ b/fs/ext2/super.c
> @@ -1395,8 +1395,10 @@ static ssize_t ext2_quota_write(struct super_block *sb, int type,
> blk++;
> }
> out:
> - if (len == towrite)
> + if (len == towrite) {
> + mutex_unlock(&inode->i_mutex);
> return err;
> + }
> if (inode->i_size < off+len-towrite)
> i_size_write(inode, off+len-towrite);
> inode->i_version++;
Thanks for the patch but I already have this patch in my quota tree from
Dan Carpenter...

Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR