From: Theodore Tso <tytso@mit.edu>
To: Eric Sandeen <sandeen@redhat.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: Make the extent validity check more paranoid
Date: Thu, 23 Apr 2009 00:19:14 -0400 [thread overview]
Message-ID: <20090423041914.GA2723@mit.edu> (raw)
In-Reply-To: <49EFCCAE.6050602@redhat.com>
On Wed, Apr 22, 2009 at 09:04:30PM -0500, Eric Sandeen wrote:
> Theodore Ts'o wrote:
> > Instead of just checking that the extent block number is greater or
> > equal than s_first_data_block, make sure it it is not pointing into
> > the block group descriptors, since that is clearly wrong. This helps
> > prevent filesystem from getting very badly corrupted in case an extent
> > block is corrupted.
> >
> > Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
>
> Good idea. Maybe we can get our friends with the corrupted fs to run
> with these validation patches... I can get this into rawhide at least.
Yeah, unfortunately this patch requires some other patches that went
in during the 2.6.30 merge window, so some extra back-porting would be
needed for our friends running a 2.6.29.1 Fedora kernel.
I'm still trying figure out what's the best way to add the right kind
of checking for 2.6.29 based kernels. Looking at the dump files which
Kevin Shanahan, it doesn't look like they are coming from interior
nodes of extent trees. Some kind of kludge patch into the block
device layer might be the most fool-proof way to do things.
- Ted
next prev parent reply other threads:[~2009-04-23 4:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-23 1:29 [PATCH] ext4: Make the extent validity check more paranoid Theodore Ts'o
2009-04-23 2:04 ` Eric Sandeen
2009-04-23 4:19 ` Theodore Tso [this message]
2009-04-23 12:52 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090423041914.GA2723@mit.edu \
--to=tytso@mit.edu \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).