From: Andreas Dilger <adilger@sun.com>
To: Chris Mason <chris.mason@oracle.com>
Cc: Jan Kara <jack@suse.cz>,
Linus Torvalds <torvalds@linux-foundation.org>,
"Theodore Ts'o" <tytso@mit.edu>,
Linux Kernel Developers List <linux-kernel@vger.kernel.org>,
Ext4 Developers List <linux-ext4@vger.kernel.org>,
Mike Galbraith <efault@gmx.de>
Subject: Re: [PATCH RFC] ext3 data=guarded v5
Date: Wed, 29 Apr 2009 13:47:31 -0600 [thread overview]
Message-ID: <20090429194731.GJ3209@webber.adilger.int> (raw)
In-Reply-To: <1241016181.20099.31.camel@think.oraclecorp.com>
On Apr 29, 2009 10:43 -0400, Chris Mason wrote:
> On Wed, 2009-04-29 at 10:08 -0400, Chris Mason wrote:
> > This would mean IO completion (clearing PG_writeback) would have to wait
> > on the inode mutex, which we can't quite do in O_SYNC and O_DIRECT.
> > But, what I can do is check i_nlink after the ext3_orphan_del call and
> > put the inode back on the orphan list if it has gone to zero.
>
> Ugh, that won't work, we'll just race with link and risk an orphan that
> never gets removed. I'll make a version of ext3_orphan_del that expects
> the super lock held and use that instead.
I looks like ext3_link() checks for i_nlink == 0 and returns -ENOENT to
avoid this race.
Cheers, Andreas
--
Andreas Dilger
Sr. Staff Engineer, Lustre Group
Sun Microsystems of Canada, Inc.
next prev parent reply other threads:[~2009-04-29 19:47 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-28 18:04 [PATCH RFC] ext3 data=guarded v5 Chris Mason
2009-04-28 18:33 ` Mike Galbraith
2009-04-28 18:54 ` Chris Mason
2009-04-29 2:12 ` KOSAKI Motohiro
2009-04-29 8:56 ` Jan Kara
2009-04-29 14:08 ` Chris Mason
2009-04-29 14:43 ` Chris Mason
2009-04-29 19:47 ` Andreas Dilger [this message]
2009-04-29 19:15 ` Jan Kara
2009-04-29 19:41 ` Chris Mason
2009-04-29 20:04 ` Jan Kara
2009-04-29 20:37 ` Chris Mason
2009-04-30 11:38 ` Jan Kara
2009-04-29 21:53 ` Theodore Tso
2009-04-29 19:51 ` [PATCH RFC] ext3 data=guarded v6 Chris Mason
2009-04-29 20:21 ` Jan Kara
2009-04-29 20:53 ` [PATCH RFC] ext3 data=guarded v7 Chris Mason
2009-04-30 11:52 ` Jan Kara
2009-04-30 13:17 ` Chris Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090429194731.GJ3209@webber.adilger.int \
--to=adilger@sun.com \
--cc=chris.mason@oracle.com \
--cc=efault@gmx.de \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).