public inbox for linux-ext4@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: "Christoph Hellwig" <hch@lst.de>,
	linux-kernel@vger.kernel.org,
	"Frédéric Weisbecker" <fweisbec@gmail.com>,
	"Steven Rostedt" <rostedt@goodmis.org>,
	"Theodore Ts'o" <tytso@mit.edu>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4/jbd2: remove stray markers
Date: Wed, 6 May 2009 13:03:54 +0200	[thread overview]
Message-ID: <20090506110354.GG25203@elte.hu> (raw)
In-Reply-To: <20090506104436.GA24047@lst.de>


* Christoph Hellwig <hch@lst.de> wrote:

> ext4/jbd2 has a couple of stray markers without any users 
> introduced in commit ba80b1019aa722b24506db1ee755e0bb2f513022 
> (which has a very useless changelog, btw).  Remove them in 
> preparation of removing the markers in favour of the TRACE_EVENT 
> macro (and also because we don't keep dead code around).
> 
> Ted, I think you have some TRAVE_EVENT patches for ext4 pending, 
> but is it okay to queue up this removal in the tracing tree?  That 
> way we can remove the markers leftovers there completely as soon 
> as the 2.6.31 merge window opens.

i think these markers are still in active use, so i'd not remove 
them before Ted's TRACE_EVENT() changes are included. We can/should 
do that in a single topic - in a work flow that suits Ted best.

We can do a -git based special-purpose topic branch in -tip, or we 
can do it in tip/tracing, or we can pull a (-git based) branch from 
Ted. Or we can delay it all to the v2.6.31 merge window. Ted's 
choice.

	Ingo

  reply	other threads:[~2009-05-06 11:04 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-06 10:44 [PATCH] ext4/jbd2: remove stray markers Christoph Hellwig
2009-05-06 11:03 ` Ingo Molnar [this message]
2009-05-06 11:07   ` Christoph Hellwig
2009-05-06 11:12     ` Ingo Molnar
2009-05-06 11:40   ` Theodore Tso
2009-05-06 11:44     ` Christoph Hellwig
2009-05-06 11:58       ` Ingo Molnar
2009-05-06 12:55       ` Theodore Tso
2009-05-06 13:18         ` Ingo Molnar
2009-05-06 11:54     ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090506110354.GG25203@elte.hu \
    --to=mingo@elte.hu \
    --cc=fweisbec@gmail.com \
    --cc=hch@lst.de \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox