From: Theodore Tso <tytso@mit.edu>
To: Eric Sandeen <sandeen@redhat.com>
Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
cmm@us.ibm.com, linux-ext4@vger.kernel.org
Subject: Re: [PATCH 1/3] ext4: Properly initialize the buffer_head state
Date: Sun, 10 May 2009 19:57:41 -0400 [thread overview]
Message-ID: <20090510235741.GA3980@mit.edu> (raw)
In-Reply-To: <4A02FC3A.9000806@redhat.com>
On Thu, May 07, 2009 at 10:20:26AM -0500, Eric Sandeen wrote:
> Aneesh Kumar K.V wrote:
> > These buffer_heads are allocated on stack and are
> > used only to make get_blocks calls. So we can set the
> > b_state to 0
> >
> > Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
>
> I'd noticed this too, thanks for fixing up.
Is this just a clean-up, or does this fix a bug? It wasn't obvious
the patch description. (I'm not a big fan of Ingo's 'Impact: '
header, but it is good to make sure the patch description explains the
impact of a patch.)
In the long run, we should really look at cleaning up the get_blocks*
interfaces so they don't use buffer_head when all they're really doing
is passing back a block number. All aside from the confusion it
causes, it also bloats our stack usage.
- Ted
next prev parent reply other threads:[~2009-05-11 8:22 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-07 10:39 [PATCH 1/3] ext4: Properly initialize the buffer_head state Aneesh Kumar K.V
2009-05-07 10:39 ` [PATCH 2/3] ext4: Clear the unwritten buffer_head flag properly Aneesh Kumar K.V
2009-05-07 10:39 ` [PATCH 3/3] vfs: Add BUG_ON for delayed and unwritten extents in submit_bh Aneesh Kumar K.V
2009-05-07 15:37 ` Eric Sandeen
2009-05-12 3:17 ` Theodore Tso
2009-05-12 4:52 ` [PATCH 3/3] vfs: Add BUG_ON for delayed and unwritten extentsin submit_bh Aneesh Kumar K.V
2009-05-12 13:25 ` Eric Sandeen
2009-05-07 15:36 ` [PATCH 2/3] ext4: Clear the unwritten buffer_head flag properly Eric Sandeen
2009-05-08 8:12 ` Aneesh Kumar K.V
2009-05-12 3:08 ` Theodore Tso
2009-05-12 4:46 ` Aneesh Kumar K.V
2009-05-13 18:56 ` Eric Sandeen
2009-05-13 22:28 ` Theodore Tso
2009-05-14 6:00 ` Aneesh Kumar K.V
2009-05-14 5:40 ` Aneesh Kumar K.V
2009-05-14 13:14 ` Theodore Tso
2009-05-07 15:20 ` [PATCH 1/3] ext4: Properly initialize the buffer_head state Eric Sandeen
2009-05-10 23:57 ` Theodore Tso [this message]
2009-05-11 9:24 ` Aneesh Kumar K.V
2009-05-11 11:31 ` Theodore Tso
2009-05-11 14:49 ` Eric Sandeen
2009-05-12 3:17 ` Theodore Tso
2009-05-12 4:47 ` Aneesh Kumar K.V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090510235741.GA3980@mit.edu \
--to=tytso@mit.edu \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=cmm@us.ibm.com \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).