From: Theodore Tso <tytso@mit.edu>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: cmm@us.ibm.com, sandeen@redhat.com, linux-ext4@vger.kernel.org,
Jan Kara <jack@suse.cz>
Subject: Re: [PATCH RESEND 1/2] ext4: Add inode to the orphan list during block allocation failure
Date: Mon, 11 May 2009 07:45:28 -0400 [thread overview]
Message-ID: <20090511114528.GA6277@mit.edu> (raw)
In-Reply-To: <1241428381-13874-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com>
Did you see the comments I made to the original version of your patch
(e-mail dated April 6, 2008).
The comments can be easily found in the ext4 patchwork website:
http://patchwork.ozlabs.org/patch/25380/
http://patchwork.ozlabs.org/patch/25381/
My concern is about stray inodes on the orphan list causing a panic on
umount, and it looks like these patches increases the exposure of this
happening.
- Ted
prev parent reply other threads:[~2009-05-11 11:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-04 9:13 [PATCH RESEND 1/2] ext4: Add inode to the orphan list during block allocation failure Aneesh Kumar K.V
2009-05-04 9:13 ` [PATCH RESEND 2/2] ext4: truncate the file properly if we fail to copy data from userspace Aneesh Kumar K.V
2009-05-04 11:23 ` Jan Kara
2009-05-11 11:45 ` Theodore Tso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090511114528.GA6277@mit.edu \
--to=tytso@mit.edu \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=cmm@us.ibm.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).