From: Theodore Tso <tytso@mit.edu>
To: Eric Sandeen <sandeen@redhat.com>
Cc: Jan Kara <jack@suse.cz>,
linux-ext4@vger.kernel.org, Andi Kleen <andi@firstfloor.org>
Subject: Re: [PATCH] EXT3: Change all super.c messages to print the device
Date: Wed, 20 May 2009 07:21:08 -0400 [thread overview]
Message-ID: <20090520112108.GA24836@mit.edu> (raw)
In-Reply-To: <4A130022.6090807@redhat.com>
On Tue, May 19, 2009 at 01:53:22PM -0500, Eric Sandeen wrote:
> > No, I didn't but thanks for reminding me; I agree it's a good cleanup.
> > We should get it ported over to ext4, too.
>
> I'll do that, unless anyone's already started.
If you would, that would be great.
> There's a bit of inconsistency in the patch between:
>
> ext3_msg(sb, KERN_ERR "message");
> and
> ext3_msg(sb, KERN_ERR, "message");
Obviously the second is what is preferred. :-)
If you have a chance, could you clean up Andi's patch and resend it?
I have one or two minor ext3 fixups in the ext4 tree, but we should
check and make sure Andrew isn't carrying anything major in his mmotm
tree, so as to avoid patch collisions.
- Ted
next prev parent reply other threads:[~2009-05-20 11:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-26 18:49 [PATCH] EXT3: Change all super.c messages to print the device Andi Kleen
2009-05-19 17:14 ` Jan Kara
2009-05-19 17:49 ` Theodore Tso
2009-05-19 18:53 ` Eric Sandeen
2009-05-20 11:21 ` Theodore Tso [this message]
2009-05-20 11:30 ` Andi Kleen
2009-05-20 15:50 ` Eric Sandeen
2009-05-20 16:00 ` Andi Kleen
2009-05-20 21:23 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090520112108.GA24836@mit.edu \
--to=tytso@mit.edu \
--cc=andi@firstfloor.org \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).