From: Theodore Tso <tytso@mit.edu>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: cmm@us.ibm.com, sandeen@redhat.com, linux-ext4@vger.kernel.org
Subject: Re: [PATCH -V2 3/4] ext4: Move some static functions around
Date: Thu, 4 Jun 2009 09:47:10 -0400 [thread overview]
Message-ID: <20090604134710.GI21314@mit.edu> (raw)
In-Reply-To: <1244095805-17015-3-git-send-email-aneesh.kumar@linux.vnet.ibm.com>
On Thu, Jun 04, 2009 at 11:40:04AM +0530, Aneesh Kumar K.V wrote:
> Move some static functions around so that we can
> avoid some forward declaration. Also fix some compile
> warnings
I've added this with the changelog commit:
ext4: Move __ext4_journalled_writepage() to avoid forward declaration
In addition, fix two unused variable warnings.
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
I also dropped the bh initialization in fs/ext4/namei.c:empty_dir(),
since it's clearly unnecessary and gcc 4.3.3 doesn't emit a warning.
- Ted
next prev parent reply other threads:[~2009-06-04 13:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-04 6:10 [PATCH -V2 1/4] ext4: Check for only delay or unwritten buffer_heads Aneesh Kumar K.V
2009-06-04 6:10 ` [PATCH -V2 2/4] ext4: Add generic writepage callback Aneesh Kumar K.V
2009-06-04 6:10 ` [PATCH -V2 3/4] ext4: Move some static functions around Aneesh Kumar K.V
2009-06-04 6:10 ` [PATCH -V2 4/4] ext4: Add WARN_ON on unmapped dirty buffer_heads in writepage Aneesh Kumar K.V
2009-06-04 13:50 ` Theodore Tso
2009-06-04 13:47 ` Theodore Tso [this message]
2009-06-04 12:05 ` [PATCH -V2 2/4] ext4: Add generic writepage callback Theodore Tso
2009-06-04 13:20 ` Theodore Tso
2009-06-04 13:16 ` [PATCH -V2 1/4] ext4: Check for only delay or unwritten buffer_heads Theodore Tso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090604134710.GI21314@mit.edu \
--to=tytso@mit.edu \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=cmm@us.ibm.com \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).