From: Theodore Tso <tytso@mit.edu>
To: Curt Wohlgemuth <curtw@google.com>
Cc: ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: RFC PATCH: ext4 no journal corruption with locale-gen
Date: Wed, 17 Jun 2009 19:46:04 -0400 [thread overview]
Message-ID: <20090617234604.GF7867@mit.edu> (raw)
In-Reply-To: <6601abe90906171148w1431258fvd0afa105cda9b77b@mail.gmail.com>
Hi Curt,
Thanks for your analysis of the bug. The reason for the strange logic
in ext4_set_aops() is because at the moment the code doesn't support
the combination of data=journalled && delalloc. That's why it was
explicitly checking for ext4_should_order_data() and
ext4_should_writeback_data().
We have a check for this in ext4_fill_super(), so your patch should be
safe, since the combination of ext4_should_journal_data &&
test_opt(inode->i_sb, DELALLOC) should never happen.
As to your question of whether the nodelalloc and nojournal case
should really be ext4_journalled_aops, I suspect ext4_writeback_aops
makes more sense. I haven't audited all of the code paths to make
sure they DTRT in the non-journalled case yet, though.
- Ted
next prev parent reply other threads:[~2009-06-17 23:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-17 18:48 RFC PATCH: ext4 no journal corruption with locale-gen Curt Wohlgemuth
2009-06-17 23:46 ` Theodore Tso [this message]
2009-06-22 16:42 ` Curt Wohlgemuth
2009-06-22 16:56 ` Aneesh Kumar K.V
2009-06-22 17:01 ` Curt Wohlgemuth
2009-06-22 21:13 ` Andreas Dilger
2009-07-01 18:35 ` Aneesh Kumar K.V
2009-07-01 18:44 ` Michael Rubin
2009-07-02 23:27 ` Xiang Wang
2009-06-29 17:50 ` Curt Wohlgemuth
2009-07-01 18:31 ` Aneesh Kumar K.V
2009-07-06 3:41 ` Theodore Tso
2009-07-06 15:30 ` Aneesh Kumar K.V
2009-07-13 13:05 ` Theodore Tso
2009-07-06 16:21 ` Xiang Wang
2009-07-09 18:30 ` Xiang Wang
2009-07-10 7:28 ` Aneesh Kumar K.V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090617234604.GF7867@mit.edu \
--to=tytso@mit.edu \
--cc=curtw@google.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).