From: Theodore Tso <tytso@mit.edu>
To: Eric Sandeen <sandeen@redhat.com>
Cc: Mike Snitzer <snitzer@gmail.com>,
ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH V2] naturally align struct ext4_allocation_request
Date: Sun, 5 Jul 2009 22:24:12 -0400 [thread overview]
Message-ID: <20090706022412.GD6706@mit.edu> (raw)
In-Reply-To: <4A441FD4.9020403@redhat.com>
On Thu, Jun 25, 2009 at 08:09:40PM -0500, Eric Sandeen wrote:
> As Ted noted, the ext4_allocation_request isn't well aligned.
>
> Looking at it with pahole we're wasting space on 64-bit
> arches...
> grouping 32-bit members together closes these holes and shrinks
> the structure by 12 bytes.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Thanks, added to the ext4 patch queue.
- Ted
prev parent reply other threads:[~2009-07-06 2:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-24 16:30 [PATCH] naturally align struct ext4_allocation_request Eric Sandeen
2009-06-26 0:50 ` Mike Snitzer
2009-06-26 1:09 ` [PATCH V2] " Eric Sandeen
2009-07-06 2:24 ` Theodore Tso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090706022412.GD6706@mit.edu \
--to=tytso@mit.edu \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=snitzer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).