* [PATCH] ext4: Add a missing return in ext4_ext_calc_credits_for_single_extent
@ 2009-07-03 10:55 Aneesh Kumar K.V
2009-07-06 3:13 ` Theodore Tso
0 siblings, 1 reply; 2+ messages in thread
From: Aneesh Kumar K.V @ 2009-07-03 10:55 UTC (permalink / raw)
To: cmm, tytso, sandeen; +Cc: linux-ext4, Aneesh Kumar K.V
When we have space in the extent tree leaf node we should be able to
insert the extent with much less journal credits. The code was doing
proper calculation but missed a return statement.
Reported-by:Andreas Dilger <adilger@sun.com>
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
---
fs/ext4/extents.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index f9ab60f..3e8889f 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -1977,6 +1977,7 @@ int ext4_ext_calc_credits_for_single_extent(struct inode *inode, int nrblocks,
*/
/* 1 bitmap, 1 block group descriptor */
ret = 2 + EXT4_META_TRANS_BLOCKS(inode->i_sb);
+ return ret;
}
}
--
1.6.3.2.363.gc5764
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-07-06 3:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-03 10:55 [PATCH] ext4: Add a missing return in ext4_ext_calc_credits_for_single_extent Aneesh Kumar K.V
2009-07-06 3:13 ` Theodore Tso
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).