From: Theodore Tso <tytso@mit.edu>
To: Curt Wohlgemuth <curtw@google.com>
Cc: ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] Fix buffer head reference leak in no-journal mode
Date: Mon, 13 Jul 2009 09:08:29 -0400 [thread overview]
Message-ID: <20090713130829.GB12833@mit.edu> (raw)
In-Reply-To: <6601abe90907091010u526b84afxdbb0ea00c4ab2fd8@mail.gmail.com>
On Thu, Jul 09, 2009 at 10:10:55AM -0700, Curt Wohlgemuth wrote:
> We found a problem with buffer head reference leaks when using an ext4
> partition without a journal. In particular, calls to ext4_forget() would
> not to a brelse() on the input buffer head, which will cause pages they
> belong to to not be reclaimable.
>
> Further investigation showed that all places where ext4_journal_forget() and
> ext4_journal_revoke() are called are subject to the same problem. The patch
> below changes __ext4_journal_forget/__ext4_journal_revoke to do an explicit
> release of the buffer head when the journal handle isn't valid.
>
> Signed-off-by: Curt Wohlgemuth <curtw@google.com>
Thanks, applied.
- Ted
prev parent reply other threads:[~2009-07-13 13:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-09 17:10 [PATCH] Fix buffer head reference leak in no-journal mode Curt Wohlgemuth
2009-07-13 13:08 ` Theodore Tso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090713130829.GB12833@mit.edu \
--to=tytso@mit.edu \
--cc=curtw@google.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).