linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andreas Dilger <adilger@sun.com>
To: Frank Mayhar <fmayhar@google.com>
Cc: Eric Sandeen <sandeen@redhat.com>,
	Curt Wohlgemuth <curtw@google.com>,
	ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: Question on fallocate/ftruncate sequence
Date: Thu, 23 Jul 2009 15:56:14 -0600	[thread overview]
Message-ID: <20090723215614.GF4231@webber.adilger.int> (raw)
In-Reply-To: <1248372301.31323.2.camel@bobble.smo.corp.google.com>

On Jul 23, 2009  11:05 -0700, Frank Mayhar wrote:
> On Thu, 2009-07-23 at 12:00 -0500, Eric Sandeen wrote:
> > Sorry I skimmed to fast, skipped over the fsck part.  But:
> > 
> > # touch /mnt/test/testfile
> > # /root/fallocate -n -l 16m /mnt/test/testfile
> > # ls -l /mnt/test/testfile
> > -rw-r--r-- 1 root root 0 Jul 23 12:13 /mnt/test/testfile
> > # du -h /mnt/test/testfile
> > 16M	/mnt/test/testfile
> > 
> > there doesn't seem to be a problem in fsck w/ block past EOF, or am I
> > missing something else?
> 
> I was taking Andreas' word for it but now that you mention it, I see the
> same thing.  Andreas, did you have a specific case in mind?

Ted and I had discussed this in the past, maybe he fixed e2fsck to not
change the file size when there are blocks allocated beyond EOF.  Having
a flag wouldn't be a terrible idea, IMHO, so that e2fsck can make a
better decision on whether the size or the blocks count are more correct.
I'm not dead set on it.

Cheers, Andreas
--
Andreas Dilger
Sr. Staff Engineer, Lustre Group
Sun Microsystems of Canada, Inc.


  reply	other threads:[~2009-07-23 21:56 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-20 16:36 Question on fallocate/ftruncate sequence Curt Wohlgemuth
2009-07-20 22:45 ` Eric Sandeen
2009-07-21 21:29   ` Frank Mayhar
2009-07-21 21:54     ` Andreas Dilger
2009-07-22 16:24       ` Frank Mayhar
2009-07-22 23:10       ` Frank Mayhar
2009-07-23  3:05         ` Eric Sandeen
2009-07-23 16:27           ` Frank Mayhar
2009-07-23 17:00             ` Eric Sandeen
2009-07-23 18:05               ` Frank Mayhar
2009-07-23 21:56                 ` Andreas Dilger [this message]
2009-07-23 22:46                   ` Frank Mayhar
2009-08-28 18:42                     ` Jiaying Zhang
2009-08-28 19:40                       ` Andreas Dilger
2009-08-28 21:44                         ` Jiaying Zhang
2009-08-28 22:14                           ` Andreas Dilger
2009-08-29  0:40                             ` Jiaying Zhang
2009-08-30  2:52                               ` Theodore Tso
2009-08-31 19:40                                 ` Jiaying Zhang
2009-08-31 21:56                                   ` Andreas Dilger
2009-08-31 23:33                                     ` Jiaying Zhang
2009-09-02  8:41                                       ` Andreas Dilger
2009-09-03  5:20                                         ` Jiaying Zhang
2009-09-03  5:32                                           ` Jiaying Zhang
2009-09-24  5:27                                           ` Jiaying Zhang
2009-09-25  7:35                                             ` Andreas Dilger
2009-09-25 22:08                                               ` Jiaying Zhang
2009-09-29 19:15                                             ` Eric Sandeen
2009-09-29 19:38                                               ` Jiaying Zhang
2009-09-29 19:55                                                 ` Eric Sandeen
2009-09-30  8:10                                                   ` Andreas Dilger
2009-10-02 22:10                                                   ` Jiaying Zhang
2009-10-02 22:29                                                     ` Eric Sandeen
2009-10-02 23:21                                                       ` Jiaying Zhang
2009-07-23 19:48       ` Question on fallocate/ftruncate sequence (and flags) Frank Mayhar
2009-07-23 20:37         ` Eric Sandeen
2009-07-23 21:01           ` Frank Mayhar
2009-07-29 15:29             ` Jan Kara
2009-07-29 15:59               ` Frank Mayhar
2009-07-23 21:53           ` Andreas Dilger
2009-07-23 23:33             ` Greg Freemyer
2009-07-21 22:03   ` Question on fallocate/ftruncate sequence Eric Sandeen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090723215614.GF4231@webber.adilger.int \
    --to=adilger@sun.com \
    --cc=curtw@google.com \
    --cc=fmayhar@google.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=sandeen@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).