From: Theodore Tso <tytso@mit.edu>
To: Alexander Shishkin <alexander.shishckin@gmail.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] [RFC] mkjournal: zero journal blocks only when necessary
Date: Wed, 29 Jul 2009 13:16:49 -0400 [thread overview]
Message-ID: <20090729171649.GB14105@mit.edu> (raw)
In-Reply-To: <1248883096-2294-1-git-send-email-alexander.shishckin@gmail.com>
On Wed, Jul 29, 2009 at 06:58:16PM +0300, Alexander Shishkin wrote:
> Will something like this do?
>
> The only blocks that might theoretically (although very unlikely) be
> dangerous for newly-created filesystem's integrity are those that
> still contain valid signatures, others can be safely skipped.
>
> Since reads are generally faster (or at least, not slower), this
> gives some performance increase during mkfs run.
Did you bother benchmarking what this would do on normal disk drives?
Previously we were writing out the blocks to be zeroed in large chunks
at a time for speed reasons. This patch reduces it to reading the
journal one block at a time, and if it contains a valid signature it
writes a zero block.
The patch also doesn't check for commit blocks, which are just as much
a problem (if not more so) than revoke blocks.
- Ted
prev parent reply other threads:[~2009-07-29 17:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-11 15:03 [Q] ext3 mkfs: zeroing journal blocks Alexander Shishkin
2009-05-11 17:58 ` Eric Sandeen
2009-05-11 18:20 ` Andreas Dilger
2009-05-11 18:44 ` Eric Sandeen
2009-05-11 19:35 ` Theodore Tso
2009-05-11 19:35 ` Andreas Dilger
2009-05-12 11:55 ` Alexander Shishkin
2009-05-12 12:13 ` Theodore Tso
2009-05-12 12:49 ` Alexander Shishkin
2009-05-12 21:04 ` Theodore Tso
2009-07-29 15:58 ` [PATCH] [RFC] mkjournal: zero journal blocks only when necessary Alexander Shishkin
2009-07-29 17:16 ` Theodore Tso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090729171649.GB14105@mit.edu \
--to=tytso@mit.edu \
--cc=alexander.shishckin@gmail.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).