From: Arnd Bergmann <arnd@arndb.de>
To: Mark Lord <lkml@rtr.ca>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
linux-ext4@vger.kernel.org, Eric Sandeen <sandeen@sandeen.net>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] fs/compat_ioctl.c: add missing FS_IOC_FIEMAP support
Date: Mon, 3 Aug 2009 20:00:11 +0200 [thread overview]
Message-ID: <200908032000.12260.arnd@arndb.de> (raw)
In-Reply-To: <4A7722DF.80704@rtr.ca>
On Monday 03 August 2009, Mark Lord wrote:
> (resending, no ack from anyone first time around).
I actually wrote a lengthy reply on how I think the code around it
should be done differently and then realized why we had done it
that way originally and did not send out my reply.
Your addition looks ok, the data structures are compatible
on all architectures.
> Add support for the FIEMAP ioctl for 32-bit user on 64-bit kernel.
>
> When using a 32-bit runtime on top of a 64-bit kernel,
> programs like "filefrag" and "hdparm --fibmap" do not work correctly.
>
> This is because there's no compat ioctl entry for the FIEMAP call.
> FIEMAP returns file extent info, similar to FIBMAP (but better).
>
> Since FIBMAP itself is b0rked on ext4, this leaves no way for a 32-bit
> program to reliably get detailed block information for a file
> when run on top of a 64-bit kernel. This patch addresses the issue.
>
> Once upstream, this patch could also be a candidate for -stable.
>
> Signed-off-by: Mark Lord <mlord@pobox.com>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
next prev parent reply other threads:[~2009-08-03 18:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-01 14:59 [PATCH] fs/compat_ioctl.c: add missing FS_IOC_FIEMAP support Mark Lord
2009-08-01 15:17 ` Mark Lord
2009-08-03 17:48 ` Mark Lord
2009-08-03 18:00 ` Arnd Bergmann [this message]
2009-08-03 18:00 ` Eric Sandeen
2009-08-03 22:07 ` Mark Lord
2009-08-03 22:21 ` Eric Sandeen
2009-08-03 23:22 ` Andrew Morton
2009-08-04 10:39 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200908032000.12260.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=akpm@linux-foundation.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkml@rtr.ca \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).