From: Andreas Dilger <adilger@sun.com>
To: Valerie Aurora <vaurora@redhat.com>
Cc: Theodore Tso <tytso@mit.edu>, Julia Lawall <julia@diku.dk>,
linux-ext4@vger.kernel.org, Eric Sandeen <sandeen@redhat.com>,
Ric Wheeler <rwheeler@redhat.com>,
Jesper Andersen <jespera@diku.dk>
Subject: Re: spatch for 64-bit e2fsprogs (was Re: Fix device too big bug in mainline?)
Date: Tue, 04 Aug 2009 13:24:08 -0600 [thread overview]
Message-ID: <20090804192408.GE3340@webber.adilger.int> (raw)
In-Reply-To: <20090804181850.GF9324@shell>
Semantic patches... a very interesting idea.
On Aug 04, 2009 14:18 -0400, Valerie Aurora wrote:
> // Free blocks
> -fs->group_desc[group].bg_free_blocks_count++
> +ext2fs_bg_free_blocks_count_set(fs, group, ext2fs_bg_free_blocks_count(fs, group)+1)
> |
> -fs->group_desc[group].bg_free_blocks_count--
> +ext2fs_bg_free_blocks_count_set(fs, group, ext2fs_bg_free_blocks_count(fs, group)-1)
> |
> -fs->group_desc[group].bg_free_blocks_count += i
> +ext2fs_bg_free_blocks_count_set(fs, group, ext2fs_bg_free_blocks_count(fs, group)+i)
> |
> -fs->group_desc[group].bg_free_blocks_count -= i
> +ext2fs_bg_free_blocks_count_set(fs, group, ext2fs_bg_free_blocks_count(fs, group)-i)
I wonder if it makes more sense for ext2fs to export functions like
ext2fs_bg_free_blocks_count_add() and ext2fs_bg_free_blocks_count_sub()?
> -fs->group_desc[group].bg_flags & flag
> +ext2fs_bg_flag_test(fs, group, flag)
> |
> -fs->group_desc[group].bg_flags &= ~flag
> +ext2fs_bg_flag_clear(fs, group, flag)
> |
> -fs->group_desc[group].bg_flags |= flag
> +ext2fs_bg_flag_set(fs, group, flag)
> |
> -fs->group_desc[group].bg_flags = 0
> +ext2fs_bg_flags_clear(fs, group, 0)
This last one looks like an error. To clear the flags you should
use ext2fs_bg_flags_set(fs, group, 0), otherwise you are "clearing
no flags".
Cheers, Andreas
--
Andreas Dilger
Sr. Staff Engineer, Lustre Group
Sun Microsystems of Canada, Inc.
next prev parent reply other threads:[~2009-08-04 19:24 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-30 21:53 Fix device too big bug in mainline? Valerie Aurora
2009-08-02 0:28 ` Theodore Tso
2009-08-02 2:22 ` Theodore Tso
2009-08-02 3:49 ` Theodore Tso
2009-08-03 20:11 ` Valerie Aurora
2009-08-03 20:27 ` spatch for 64-bit e2fsprogs (was Re: Fix device too big bug in mainline?) Valerie Aurora
2009-08-03 22:56 ` Valerie Aurora
2009-08-04 6:40 ` Julia Lawall
2009-08-04 14:48 ` Theodore Tso
2009-08-04 18:18 ` Valerie Aurora
2009-08-04 19:24 ` Andreas Dilger [this message]
2009-08-04 19:58 ` Valerie Aurora
2009-08-04 20:32 ` Theodore Tso
2009-08-04 18:28 ` Fix device too big bug in mainline? Valerie Aurora
2009-08-04 20:41 ` Theodore Tso
2009-08-04 21:29 ` Valerie Aurora
2009-08-04 22:12 ` Theodore Tso
2009-08-04 23:56 ` Theodore Tso
2009-08-03 18:04 ` Valerie Aurora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090804192408.GE3340@webber.adilger.int \
--to=adilger@sun.com \
--cc=jespera@diku.dk \
--cc=julia@diku.dk \
--cc=linux-ext4@vger.kernel.org \
--cc=rwheeler@redhat.com \
--cc=sandeen@redhat.com \
--cc=tytso@mit.edu \
--cc=vaurora@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).