From: Theodore Tso <tytso@mit.edu>
To: Eric Sandeen <sandeen@redhat.com>
Cc: linux-ext4@vger.kernel.org, Andreas Dilger <adilger@sun.com>,
Alex Tomas <bzzz@sun.com>
Subject: Re: [PATCH, RFC -V2 1/4] ext4: Add configurable run-time mballoc debugging
Date: Mon, 10 Aug 2009 16:23:24 -0400 [thread overview]
Message-ID: <20090810202324.GE1756@mit.edu> (raw)
In-Reply-To: <4A7F9719.1030209@redhat.com>
On Sun, Aug 09, 2009 at 10:42:17PM -0500, Eric Sandeen wrote:
> Theodore Ts'o wrote:
> > Allow mballoc debugging to be enabled at run-time instead of just at
> > compile time.
> >
> > Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
> > ---
> > fs/ext4/Kconfig | 9 ++++++
> > fs/ext4/mballoc.c | 81 ++++++++++++++++++++++++++++++++++++++--------------
> > fs/ext4/mballoc.h | 16 ++++++++--
> > 3 files changed, 80 insertions(+), 26 deletions(-)
>
> This looks fine to me, though is there any reason to add the debug
> verbosity level at this point, when it's all just "1?"
What I'm thinking about doing is to use a bitmask instead of a
verbosity level. That way it will be possible to selectively enable
some debugging print messages and not others.
In the long run the right answer is to use ftrace instead, but this is
faster and more convenient when doing surgery/development on the
mballoc code.
- Ted
next prev parent reply other threads:[~2009-08-10 20:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-10 3:23 [PATCH, RFC -V2 0/4] mballoc patches for ext4 Theodore Ts'o
2009-08-10 3:23 ` [PATCH, RFC -V2 1/4] ext4: Add configurable run-time mballoc debugging Theodore Ts'o
2009-08-10 3:42 ` Eric Sandeen
2009-08-10 20:23 ` Theodore Tso [this message]
2009-08-11 18:15 ` Xiang Wang
2009-08-11 18:53 ` Theodore Tso
2009-08-10 3:23 ` [PATCH, RFC -V2 2/4] ext4: Display the mballoc flags in mb_history in hex instead of decimal Theodore Ts'o
2009-08-10 3:44 ` Eric Sandeen
2009-08-10 3:23 ` [PATCH, RFC -V2 3/4] ext4: Fix bugs in mballoc's stream allocation mode Theodore Ts'o
2009-08-20 7:22 ` Aneesh Kumar K.V
2009-08-20 18:20 ` Theodore Tso
2009-08-10 3:23 ` [PATCH, RFC -V2 4/4] ext4: Avoid group preallocation for closed files Theodore Ts'o
2009-08-20 6:40 ` Aneesh Kumar K.V
2009-08-21 2:45 ` Theodore Tso
2009-08-21 12:23 ` Theodore Tso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090810202324.GE1756@mit.edu \
--to=tytso@mit.edu \
--cc=adilger@sun.com \
--cc=bzzz@sun.com \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).