From: Theodore Tso <tytso@mit.edu>
To: Xiang Wang <xiangw@google.com>
Cc: linux-ext4@vger.kernel.org, Andreas Dilger <adilger@sun.com>,
Alex Tomas <bzzz@sun.com>, Curt Wohlgemuth <curtw@google.com>
Subject: Re: [PATCH, RFC -V2 1/4] ext4: Add configurable run-time mballoc debugging
Date: Tue, 11 Aug 2009 14:53:57 -0400 [thread overview]
Message-ID: <20090811185357.GP1756@mit.edu> (raw)
In-Reply-To: <d5ca277e0908111115g4274b419g490bc453eaf6e1bd@mail.gmail.com>
On Tue, Aug 11, 2009 at 11:15:53AM -0700, Xiang Wang wrote:
> Hi Ted,
>
> I tried to apply this patch to our kernel, but I encountered some
> problems in building the kernel:
>
> FATAL: fs/ext4/ext4.o(.text+0x24f2d): Section mismatch in reference
> from the function exit_ext4_mballoc() to the function
> .exit.text:ext4_remove_debugfs_entry()
>
> Looking at the code, the problem seems to be that, exit_ext4_mballoc
> calls ext4_remove_debugfs_entry. And ext4_remove_debugfs_entry has the
> "__exit" annotation while exit_ext4_mballoc does not. I tried removing
> the "__exit" annotation from ext4_remove_debugfs_entry and it builds
> well.
Good catch; I didn't notice because I wasn't compiling with
CONFIG_DEBUG_SECTION_MISMATCH=y. Your fix is the right one.
- Ted
next prev parent reply other threads:[~2009-08-11 18:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-10 3:23 [PATCH, RFC -V2 0/4] mballoc patches for ext4 Theodore Ts'o
2009-08-10 3:23 ` [PATCH, RFC -V2 1/4] ext4: Add configurable run-time mballoc debugging Theodore Ts'o
2009-08-10 3:42 ` Eric Sandeen
2009-08-10 20:23 ` Theodore Tso
2009-08-11 18:15 ` Xiang Wang
2009-08-11 18:53 ` Theodore Tso [this message]
2009-08-10 3:23 ` [PATCH, RFC -V2 2/4] ext4: Display the mballoc flags in mb_history in hex instead of decimal Theodore Ts'o
2009-08-10 3:44 ` Eric Sandeen
2009-08-10 3:23 ` [PATCH, RFC -V2 3/4] ext4: Fix bugs in mballoc's stream allocation mode Theodore Ts'o
2009-08-20 7:22 ` Aneesh Kumar K.V
2009-08-20 18:20 ` Theodore Tso
2009-08-10 3:23 ` [PATCH, RFC -V2 4/4] ext4: Avoid group preallocation for closed files Theodore Ts'o
2009-08-20 6:40 ` Aneesh Kumar K.V
2009-08-21 2:45 ` Theodore Tso
2009-08-21 12:23 ` Theodore Tso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090811185357.GP1756@mit.edu \
--to=tytso@mit.edu \
--cc=adilger@sun.com \
--cc=bzzz@sun.com \
--cc=curtw@google.com \
--cc=linux-ext4@vger.kernel.org \
--cc=xiangw@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).