From: Theodore Tso <tytso@mit.edu>
To: Mingming <cmm@us.ibm.com>
Cc: linux-ext4@vger.kernel.org, Eric Sandeen <sandeen@redhat.com>,
Jan Kara <jack@suse.cz>, Curt Wohlgemuth <curtw@google.com>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Subject: Re: [RFC,PATCH 2/2] Direct IO for holes and fallocate
Date: Mon, 17 Aug 2009 20:18:31 -0400 [thread overview]
Message-ID: <20090818001831.GB1215@mit.edu> (raw)
In-Reply-To: <1249916431.4337.33.camel@mingming-laptop>
Here's my suggest rewrite of the patch description:
ext4: Direct IO for holes and fallocate: unwritten extents spt for DIO
From: Mingming <cmm@us.ibm.com>
When writing into an unitialized extent via direct I/O, and the direct
I/O doesn't exactly cover the unitialized extent, split the extent
into uninitialized and initialized extents before submitting the I/O.
The reason for doing this is to avoid needing to deal with an ENOSPC
error in the end_io callback that gets used for direct I/O.
Singed-Off-By: Mingming Cao <cmm@us.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
------------------
As mentioned in my comments for the previous patch,
ext4_convert_unwritten_extents() needs to be defined in the previous
patch. This may requiring dragging in substantial portions of this
patch.
The other observation is there seems to be quite a bit of overlap
between ext4_split_unwritten_extents() and
ext4_ext_convert_to_initialized(). Is there some way we can do some
code factorization?
- Ted
next prev parent reply other threads:[~2009-08-18 0:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-10 15:00 [RFC,PATCH 2/2] Direct IO for holes and fallocate Mingming
2009-08-18 0:18 ` Theodore Tso [this message]
2009-08-18 22:49 ` Mingming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090818001831.GB1215@mit.edu \
--to=tytso@mit.edu \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=cmm@us.ibm.com \
--cc=curtw@google.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).