From: Andreas Dilger <adilger@sun.com>
To: "Theodore Ts'o" <tytso@mit.edu>
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH 2/2] ext4: Automatically enable journal_async_commit on ext4 file systems
Date: Sun, 06 Sep 2009 00:57:47 +0200 [thread overview]
Message-ID: <20090905225747.GP4197@webber.adilger.int> (raw)
In-Reply-To: <1252189963-23868-2-git-send-email-tytso@mit.edu>
On Sep 05, 2009 18:32 -0400, Theodore Ts'o wrote:
> Now that we have cleaned up journal_async_commit, it's safe to enable
> it all the time. But we only want to do so if ext4-specific INCOMPAT
> features are enabled, since otherwise we will prevent the filesystem
> from being mounted using ext3.
So, the big question is what to do if not-the-last transaction in the
journal has a bad block in it? This is fairly unlikely, and IMHO the
harm of aborting journal replay too early is likely far outweighed by
the benefit of not "recovering" garbage directly over the filesystem
metadata.
I had thought that you had rejected the e2fsck side of this patch for
that reason, but maybe my memory is faulty... We still have some
test images for bad journal checksums that you can have if you want.
Cheers, Andreas
--
Andreas Dilger
Sr. Staff Engineer, Lustre Group
Sun Microsystems of Canada, Inc.
next prev parent reply other threads:[~2009-09-05 22:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-05 22:32 [PATCH 1/2] ext4: Remove journal_checksum mount option and enable it by default Theodore Ts'o
2009-09-05 22:32 ` [PATCH 2/2] ext4: Automatically enable journal_async_commit on ext4 file systems Theodore Ts'o
2009-09-05 22:57 ` Andreas Dilger [this message]
2009-09-06 1:32 ` Theodore Tso
2009-09-06 2:57 ` Eric Sandeen
2009-09-07 23:48 ` Ric Wheeler
2009-09-07 23:42 ` Ric Wheeler
2009-09-08 4:45 ` Theodore Tso
2009-09-08 11:50 ` Ric Wheeler
2009-09-11 2:45 ` Theodore Tso
2009-09-11 11:07 ` Ric Wheeler
2009-09-11 13:13 ` Theodore Tso
2009-09-11 14:39 ` Ric Wheeler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090905225747.GP4197@webber.adilger.int \
--to=adilger@sun.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).