From: Theodore Tso <tytso@mit.edu>
To: Eric Sandeen <sandeen@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: fix cache flish in ext4_sync_file
Date: Sat, 5 Sep 2009 21:43:16 -0400 [thread overview]
Message-ID: <20090906014316.GE2287@mit.edu> (raw)
In-Reply-To: <4A9D669F.1040508@redhat.com>
On Tue, Sep 01, 2009 at 01:23:27PM -0500, Eric Sandeen wrote:
> Christoph Hellwig wrote:
> > We need to flush the write cache unconditionally in ->fsync, otherwise
> > writes into already allocated blocks can get lost. Writes into fully
> > allocated files are very common when using disk images for
> > virtualization, and without this fix can easily lose data after
> > an fdatasync, which is the typical implementation for a cache flush on
> > the virtual drive.
> >
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Fixing my old commit, I guess ;)
Added to the ext4 patch queue (with the "flish" corrected to "flush")
- Ted
prev parent reply other threads:[~2009-09-06 1:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-31 19:35 [PATCH] ext4: fix cache flish in ext4_sync_file Christoph Hellwig
2009-09-01 18:23 ` Eric Sandeen
2009-09-06 1:43 ` Theodore Tso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090906014316.GE2287@mit.edu \
--to=tytso@mit.edu \
--cc=hch@lst.de \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).