From: Theodore Tso <tytso@mit.edu>
To: Akira Fujita <a-fujita@rs.jp.nec.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH 1/4]ext4: Fix wrong comparisons in mext_check_arguments()
Date: Sat, 5 Sep 2009 22:10:32 -0400 [thread overview]
Message-ID: <20090906021032.GA3055@mit.edu> (raw)
In-Reply-To: <4A9DE3DE.2010509@rs.jp.nec.com>
On Wed, Sep 02, 2009 at 12:17:50PM +0900, Akira Fujita wrote:
> ext4: Fix wrong comparisons in mext_check_arguments()
>
> From: Akira Fujita <a-fujita@rs.jp.nec.com>
>
> mext_check_arguments() in move_extents.c has wrong comparisons.
> orig_start which is passed from user-space is block unit,
> but i_size of inode is byte unit, therefore the checks do not work fine.
> This mis-check leads to the overflow of 'len' and then hits BUG_ON()
> in ext4_move_extens(). The patch fixes this issue.
Thanks, I've added this to the ext4 patch queue to be pushed when the
2.6.32 merge window opens.
- Ted
next prev parent reply other threads:[~2009-09-06 2:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-02 3:17 [PATCH 1/4]ext4: Fix wrong comparisons in mext_check_arguments() Akira Fujita
2009-09-02 16:02 ` Peng Tao
2009-09-06 2:10 ` Theodore Tso [this message]
2009-09-16 4:56 ` Akira Fujita
2009-09-16 18:37 ` Theodore Tso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090906021032.GA3055@mit.edu \
--to=tytso@mit.edu \
--cc=a-fujita@rs.jp.nec.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).