From: Theodore Tso <tytso@mit.edu>
To: Eric Sandeen <sandeen@redhat.com>
Cc: ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] e2fsck: avoid overflow in pass5 check_block_end()
Date: Sun, 6 Sep 2009 13:57:18 -0400 [thread overview]
Message-ID: <20090906175718.GM3055@mit.edu> (raw)
In-Reply-To: <4A9DA2DC.10001@redhat.com>
On Tue, Sep 01, 2009 at 05:40:28PM -0500, Eric Sandeen wrote:
> When making a filesystem as in:
>
> mke2fs -E lazy_itable_init=1 -O uninit_bg -b 4096 bigfile 4294967298
>
> a subsequent fsck would result in:
>
> Pass 5: Checking group summary information
> Internal error: fudging end of bitmap (3)
> e2fsck: aborted
>
> This is because check_block_end() was overflowing in the calculation
> for "end", and giving it a value of -1 (0xFFFF....) which eventually
> ended up tripping up a test in ext2fs_fudge_generic_bmap_end,
>
> if (end > bitmap->real_end)
> return neq;
>
> Fix another such error in read_bitmaps() as well.
>
> lib/ext2fs/imager.c likely has similar problems but it looks like
> it has no 64-bit treatment at all yet.
Applied to the e2fsprogs 64-bit patch queue / pu.
- Ted
prev parent reply other threads:[~2009-09-06 17:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-01 22:40 [PATCH] e2fsck: avoid overflow in pass5 check_block_end() Eric Sandeen
2009-09-06 17:57 ` Theodore Tso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090906175718.GM3055@mit.edu \
--to=tytso@mit.edu \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).