From: Christoph Hellwig <hch@lst.de>
To: Jan Kara <jack@suse.cz>
Cc: Eric Sandeen <sandeen@redhat.com>, Christoph Hellwig <hch@lst.de>,
linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext3: enable cache flush in ext3_sync_file
Date: Tue, 8 Sep 2009 15:10:06 +0200 [thread overview]
Message-ID: <20090908131006.GA25208@lst.de> (raw)
In-Reply-To: <20090908130438.GA2528@atrey.karlin.mff.cuni.cz>
On Tue, Sep 08, 2009 at 03:04:38PM +0200, Jan Kara wrote:
> > Acked-by: Eric Sandeen <sandeen@redhat.com>
> But would the patch below be better? When we force a transaction
> commit we don't have to flush caches again. Or am I missing something?
If you know that you really did issue a barrier for sure you don't have
to flush the cache again. I don't know extN enough to easily figure out
how, but if this patch ensures that it's good. Same scheme should also
apply to ext4.
prev parent reply other threads:[~2009-09-08 13:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-31 19:37 [PATCH] ext3: enable cache flush in ext3_sync_file Christoph Hellwig
2009-09-01 18:24 ` Eric Sandeen
2009-09-08 13:04 ` Jan Kara
2009-09-08 13:10 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090908131006.GA25208@lst.de \
--to=hch@lst.de \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).