From: Theodore Tso <tytso@mit.edu>
To: Frank Mayhar <fmayhar@google.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] Make non-journal fsync work properly.
Date: Tue, 8 Sep 2009 18:05:04 -0400 [thread overview]
Message-ID: <20090908220504.GS22901@mit.edu> (raw)
In-Reply-To: <1252424465.17646.7.camel@bobble.smo.corp.google.com>
On Tue, Sep 08, 2009 at 08:41:05AM -0700, Frank Mayhar wrote:
> I needed to doublecheck before answering but I think I've covered that
> angle. Specifically, in ext4_write_inode the patch only calls
> ext4_do_update_inode() if s_journal is NULL, otherwise it takes the
> current path.
>
> So I think your concern is covered by the current patch. Can you take
> another look and let me know if you agree? Thanks.
It wasn't obvious from reading the diff, but after I applied the patch
and looked more closely, you're right. I'm still worried though that
the code is a bit fragile. At the very *least* the restriction that
ext4_do_update_inode's do_sync flag should only be called when there
is no journal needs to be explicitly documented. Possibly we should
have a BUG() check to enforce this restriction; although a comment
before ext4_do_update_inode() is probably enough.
- Ted
next prev parent reply other threads:[~2009-09-08 22:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-05 2:55 [PATCH] Make non-journal fsync work properly Frank Mayhar
2009-09-08 5:06 ` Theodore Tso
2009-09-08 14:57 ` Curt Wohlgemuth
2009-09-08 21:41 ` Theodore Tso
2009-09-08 15:41 ` Frank Mayhar
2009-09-08 22:05 ` Theodore Tso [this message]
2009-09-08 22:39 ` Frank Mayhar
2009-09-09 17:34 ` [PATCH] ext4: Make non-journal fsync work properly. REPOST Frank Mayhar
2009-09-10 2:55 ` Theodore Tso
2009-09-14 16:54 ` Aneesh Kumar K.V
2009-09-14 17:43 ` Frank Mayhar
2009-09-26 0:39 ` [PATCH] ext4: Make non-journal fsync work properly. (Version 3) Frank Mayhar
2009-09-29 14:09 ` Theodore Tso
2009-09-10 6:57 ` [PATCH] Make non-journal fsync work properly Aneesh Kumar K.V
2009-09-10 15:33 ` Frank Mayhar
2009-09-10 19:45 ` Theodore Tso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090908220504.GS22901@mit.edu \
--to=tytso@mit.edu \
--cc=fmayhar@google.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).