From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: Mingming <cmm@us.ibm.com>
Cc: Jan Kara <jack@suse.cz>, Theodore Tso <tytso@mit.edu>,
linux-ext4@vger.kernel.org, Eric Sandeen <sandeen@redhat.com>
Subject: Re: [PATCH 2/2 V3] allow direct IO to fallocate and holes
Date: Thu, 10 Sep 2009 13:27:30 +0530 [thread overview]
Message-ID: <20090910075730.GD8690@skywalker.linux.vnet.ibm.com> (raw)
In-Reply-To: <1252529462.19097.170.camel@mingming-laptop>
On Wed, Sep 09, 2009 at 01:51:02PM -0700, Mingming wrote:
.....
.....
> > I think fsync() still won't work correctly since it can happen user sees
> > AIO completed, calls fsync() that completes,
>
> hmm, does fsync() ensure user sees AIO data completed?
>
If we call fsync after getting AIO completion event and crash we should
ensure that the data can be read back properly. That is either
a) we should ensure that we convert the extent before returning the io
completion event
b) Or the fsync should be able to guarantee that it will force the extent
conversion pending on the file.
-aneesh
next prev parent reply other threads:[~2009-09-10 7:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-04 0:44 [PATCH 2/2 V3] allow direct IO to fallocate and holes Mingming
2009-09-07 21:57 ` Jan Kara
2009-09-09 20:51 ` Mingming
2009-09-10 7:57 ` Aneesh Kumar K.V [this message]
2009-09-10 8:54 ` Jan Kara
2009-09-10 20:17 ` Mingming
2009-09-14 11:25 ` Jan Kara
2009-09-18 22:29 ` Mingming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090910075730.GD8690@skywalker.linux.vnet.ibm.com \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=cmm@us.ibm.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).