From: Andreas Dilger <adilger@sun.com>
To: Curt Wohlgemuth <curtw@google.com>
Cc: ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH 2/2] ext4: Handle nested ext4_journal_start/stop calls without a journal
Date: Thu, 17 Sep 2009 23:50:10 -0600 [thread overview]
Message-ID: <20090918055010.GN2537@webber.adilger.int> (raw)
In-Reply-To: <6601abe90909171455g597fe672g1ca6d426e609f937@mail.gmail.com>
On Sep 17, 2009 14:55 -0700, Curt Wohlgemuth wrote:
> This patch fixes a problem with handling nested calls to
> ext4_journal_start/ext4_journal_stop, when there is no journal present.
>
> Signed-off-by: Curt Wohlgemuth <curtw@google.com>
> ---
>
> Instead of using the special value of
>
> (handle_t *)0x1
>
> to represent a handle when there is no journal present, we now use a real
> handle_t, so we can use its ref counting. The h_transaction field now
> determines if there is a journal present or not.
You _could_ just use the "handle" value as a refcount, and anything less
than, say, 4096 is considered a "special" handle. I can't imagine the
refcount being more than 3 or 4 even in extreme cases.
Cheers, Andreas
--
Andreas Dilger
Sr. Staff Engineer, Lustre Group
Sun Microsystems of Canada, Inc.
next prev parent reply other threads:[~2009-09-18 5:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-17 21:55 [PATCH 2/2] ext4: Handle nested ext4_journal_start/stop calls without a journal Curt Wohlgemuth
2009-09-18 5:50 ` Andreas Dilger [this message]
2009-09-18 18:33 ` Curt Wohlgemuth
2009-09-18 21:33 ` Curt Wohlgemuth
2009-09-23 14:39 ` Curt Wohlgemuth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090918055010.GN2537@webber.adilger.int \
--to=adilger@sun.com \
--cc=curtw@google.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).