From: Theodore Tso <tytso@mit.edu>
To: Andreas Dilger <adilger@sun.com>
Cc: Eric Sandeen <sandeen@redhat.com>,
ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH, RFC] mke2fs: get device topology values from blkid
Date: Fri, 18 Sep 2009 12:43:10 -0400 [thread overview]
Message-ID: <20090918164310.GD26991@mit.edu> (raw)
In-Reply-To: <20090918142024.GU2537@webber.adilger.int>
On Fri, Sep 18, 2009 at 08:20:24AM -0600, Andreas Dilger wrote:
> On Sep 18, 2009 09:04 -0500, Eric Sandeen wrote:
> > Andreas Dilger wrote:
> >>> + rc = blkid_probe_set_device(pr, fd, 0, 0);
> >>
> >> Is this in the e2fsprogs blkid code yet? I'm guessing not, since you
> >
> > right, not yet. I don't know what the long-term plan is for e2fsprogs
> > blkid; keeping 2 trees in sync seems like a lot of work w/o much gain...
>
> I thought that was Ted's plan? We usually recommend people to update to
> the latest e2fsprogs, yet not everyone will be able to upgrade to the
> latest util-linux, especially if it is pulling in other libraries that
> can cause package conflicts (e.g. with xfstools or similar).
I wasn't planning on keeping the blkid in e2fsprogs in sync with
util-linux-ng; however, I did want to allow people who wanted to
recompile the latest version of e2fsprogs (to pick up critical bug
fixes, for example) on existing distributions (you know, for those
silly Enterprise Linux Distro customers running RHEL 5 or SLES 11 that
pay some of our collective salaries :-) to be able to do so.
If there is an issue that not all versions of util-linux-ng have the
topology calls available, we'll need some autoconf magic, of course
--- especially if some community distro's have shipped or will have
shipped versions of util-linux-ng w/o the topology functions.
I don't particularly much care about screwing over a Linux From
Scratch or Gentoo user who refuses to upgrade. I care a tiny bit more
about supporting a community distro (it's nice if we can support a
given Community distro for at least a 12 months or so before we start
making life difficult for them). But to make life easier for
Enterprise Linux users, and the Level 3 help desk people at IBM,
Novell, and Red Hat who might need the latest version of e2fsprogs to
fix some customer's file system corruption problem, we should provide
an easy way for them to download and update that customer to the
latest version of e2fsprogs. The simplest way to do that is to stub
out the new blkid topology functions has null inline functions in
blkid.h.
Does that make sense to everyone?
- Ted
next prev parent reply other threads:[~2009-09-18 16:43 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-17 22:22 [PATCH, RFC] mke2fs: get device topology values from blkid Eric Sandeen
2009-09-18 5:55 ` Andreas Dilger
2009-09-18 14:04 ` Eric Sandeen
2009-09-18 14:20 ` Andreas Dilger
2009-09-18 14:30 ` Eric Sandeen
2009-09-18 16:43 ` Theodore Tso [this message]
2009-09-18 16:57 ` Eric Sandeen
2009-09-18 6:13 ` Martin K. Petersen
2009-09-18 14:18 ` Andreas Dilger
2009-09-18 14:23 ` Eric Sandeen
2009-09-18 19:40 ` Martin K. Petersen
2009-09-18 20:28 ` Andreas Dilger
2009-09-20 20:46 ` Martin K. Petersen
2009-09-22 14:30 ` Ric Wheeler
2009-09-18 23:59 ` Karel Zak
2009-09-19 3:03 ` Eric Sandeen
2009-09-21 17:06 ` [PATCH V2] " Eric Sandeen
2009-10-02 16:32 ` [PATCH V3] " Eric Sandeen
2009-10-04 19:16 ` Theodore Tso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090918164310.GD26991@mit.edu \
--to=tytso@mit.edu \
--cc=adilger@sun.com \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).