From: Theodore Tso <tytso@mit.edu>
To: Eric Sandeen <sandeen@redhat.com>
Cc: ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] e2fsprogs: fix configure.in typo
Date: Wed, 21 Oct 2009 03:52:32 -0400 [thread overview]
Message-ID: <20091021075232.GA9574@mit.edu> (raw)
In-Reply-To: <4ADE8477.2070906@redhat.com>
On Tue, Oct 20, 2009 at 10:48:07PM -0500, Eric Sandeen wrote:
> I think vim <esc>wq turned into <esc>2wq or something; in any case
> blkid_probe_get_topology2 is not the right thing to search for.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Applied, thanks.
- Ted
> (note; with this, once I try to build w/ a new libblkid, I still
> get a mkfs build error ... it's still picking up the in-tree blkid
> headers)
Hmmm... which in-tree header files is it picking up? And what error
are you seeing?
There are a few header files that I can see that we should probably
clean-up, but they don't look like they should be problematic.
build.static/lib/blkid/blkid_types.h -- just simple type definitions
lib/blkid/blkidP.h --- only used by lib/blkid/*.c
lib/blkid/list.h --- only used by lib/blkid/*.c
lib/blkid/probe.h -- only used by lib/blkid/probe.c
next prev parent reply other threads:[~2009-10-21 7:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-21 3:48 [PATCH] e2fsprogs: fix configure.in typo Eric Sandeen
2009-10-21 7:52 ` Theodore Tso [this message]
2009-10-21 15:21 ` Eric Sandeen
2009-10-21 21:57 ` Theodore Tso
2009-10-21 22:14 ` Eric Sandeen
2009-10-21 22:19 ` Theodore Tso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091021075232.GA9574@mit.edu \
--to=tytso@mit.edu \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).