public inbox for linux-ext4@vger.kernel.org
 help / color / mirror / Atom feed
From: Jan Kara <jack@suse.cz>
To: Dmitry Monakhov <dmonakhov@openvz.org>
Cc: linux-ext4@vger.kernel.org
Subject: Re: journaled quota file question
Date: Mon, 2 Nov 2009 13:31:24 +0100	[thread overview]
Message-ID: <20091102123124.GA23161@duck.suse.cz> (raw)
In-Reply-To: <871vkj4cf3.fsf@openvz.org>

  Hi,

On Sat 31-10-09 21:59:44, Dmitry Monakhov wrote:
> Dmitry Monakhov <dmonakhov@openvz.org> writes:
> 
> > While looking to ext3/4 quota code I'm wondering
> > Why do we have to place journaled quota file on fs root?
> > In some situations it may be useful to place it deeper for example:
> > /root/dir/quota_file
> > The only reason what comes in to my mind is that some one
> > may rename parent folder rename("/root/dir", "/root/dir2")
> > Is this the only reason?
  Well, the reason is that we have to read & write the files during orphan
recovery on mount. A that time the filesystem is not fully set up so you
cannot use VFS directory traversal code and I didn't want to implement
ext[34] specific one. Also as you write above, if you have quota files in
some subdirectory, there are more possibilities for failure.
  Admittedly, I don't see a big point in having quota files in some other
directory. In fact, they should rather be system files not visible in
any directory but that requires rather non-trivial changes to repquota and
moving quotacheck functionality to fsck and I never got to doing that.

> add an author in cc:
  Thanks.

									Honza
-- 
Jan Kara <jack@suse.cz>
SUSE Labs, CR

      reply	other threads:[~2009-11-02 12:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-27  0:14 journaled quota file question Dmitry Monakhov
2009-10-31 18:59 ` Dmitry Monakhov
2009-11-02 12:31   ` Jan Kara [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091102123124.GA23161@duck.suse.cz \
    --to=jack@suse.cz \
    --cc=dmonakhov@openvz.org \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox