linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Theodore Tso <tytso@mit.edu>
To: Mingming <cmm@us.ibm.com>
Cc: ext4 development <linux-ext4@vger.kernel.org>,
	Curt Wohlgemuth <curtw@google.com>
Subject: Re: [PATCH 4/4 v2] Fix direct IO return values over fullfilled fallocate space
Date: Tue, 3 Nov 2009 21:27:07 -0500	[thread overview]
Message-ID: <20091104022707.GI6510@mit.edu> (raw)
In-Reply-To: <1255050792.4931.185.camel@mingming-laptop>

On Thu, Oct 08, 2009 at 06:13:12PM -0700, Mingming wrote:
> @@ -2827,8 +2828,8 @@ static int ext4_split_unwritten_extents(
>   	 * the size of extent to write, there is no need to split
>   	 * uninitialized extent
>   	 */
> - 	if (allocated <= max_blocks)
> -		return ret;
> + 	if (iblock == ee_block && allocated <= max_blocks)
> +		return allocated;

The change to add "iblock == ee_block" isn't explained in the patch
description and it makes the comment above the conditional no longer
accurate.

Can you add an explanation why it's necessary?

Thanks,
					- Ted

  reply	other threads:[~2009-11-04  2:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-09  1:13 [PATCH 4/4 v2] Fix direct IO return values over fullfilled fallocate space Mingming
2009-11-04  2:27 ` Theodore Tso [this message]
2009-11-06  9:02   ` Theodore Tso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091104022707.GI6510@mit.edu \
    --to=tytso@mit.edu \
    --cc=cmm@us.ibm.com \
    --cc=curtw@google.com \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).