From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: "André Goddard Rosa" <andre.goddard@gmail.com>
Cc: "Andreas Dilger" <adilger@sun.com>,
"Mike Snitzer" <snitzer@redhat.com>,
"Takashi Iwai" <tiwai@suse.de>, Kysela <perex@perex.cz>,
"Stefan Weinhuber" <wein@de.ibm.com>,
"Eric Sandeen" <sandeen@redhat.com>,
"James E . J . Bottomley" <jejb@parisc-linux.org>,
linux-cachefs@redhat.com, "WANG Cong" <wangcong@zeuux.org>,
"Len Brown" <len.brown@intel.com>,
"Trond Myklebust" <Trond.Myklebust@netapp.com>,
"Rusty Russell" <rusty@rustcorp.com.au>,
netfilter@vger.kernel.org, "Al Viro" <viro@zeniv.linux.org.uk>,
"Thomas Gleixner" <tglx@linutronix.de>,
Engelhardt <jengelh@medozas.de>,
"Bjorn Helgaas" <bjorn.helgaas@hp.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-kernel@vger.kernel.org,
"Stoyan Gaydarov" <stoyboyker@gmail.com>,
"Kyle McMartin" <kyle@mcmartin.ca>,
netfilter-devel@vger.kernel.org, "Joe Perches" <joe@perches.com>,
"Andrew Morton" <akpm@linux-foundation.org>
Subject: Re: [PATCH v4 10/12] string: factorize skip_spaces and export it to be generally available
Date: Sun, 8 Nov 2009 16:50:00 +0000 [thread overview]
Message-ID: <20091108165000.374714cb@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <c7d3b02b5e28eaa54a5360d57dfd177c44320187.1257602781.git.andre.goddard@gmail.com>
On Sat, 7 Nov 2009 13:16:18 -0200
André Goddard Rosa <andre.goddard@gmail.com> wrote:
> On the following sentence:
> while (*s && isspace(*s))
> s++;
Looks fine but for one thing: it's actually shorter inline than moved
into /lib so at the very least it should be a header inline not a
function call.
Second minor comment. Although it never made it into the final ANSI C,
the proposed name (and the one used in a lot of other non Linux code for
this) is stpblk().
Alan
next prev parent reply other threads:[~2009-11-08 16:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1257602781.git.andre.goddard@gmail.com>
2009-11-08 16:05 ` [dm-devel] [PATCH v4 00/12] introduce skip_spaces(), reducing code size plus some clean-ups James Bottomley
2009-11-08 16:52 ` André Goddard Rosa
[not found] ` <c7d3b02b5e28eaa54a5360d57dfd177c44320187.1257602781.git.andre.goddard@gmail.com>
2009-11-08 16:50 ` Alan Cox [this message]
[not found] ` <7d5883637aa976b54e944998f635d47a41618a75.1257602781.git.andre.goddard@gmail.com>
2009-11-08 18:47 ` [PATCH v4 12/12] tree-wide: convert open calls to remove spaces to skip_spaces() lib function Theodore Tso
2009-11-08 20:23 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091108165000.374714cb@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=Trond.Myklebust@netapp.com \
--cc=adilger@sun.com \
--cc=akpm@linux-foundation.org \
--cc=andre.goddard@gmail.com \
--cc=bjorn.helgaas@hp.com \
--cc=jejb@parisc-linux.org \
--cc=jengelh@medozas.de \
--cc=joe@perches.com \
--cc=kyle@mcmartin.ca \
--cc=len.brown@intel.com \
--cc=linux-cachefs@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=netfilter@vger.kernel.org \
--cc=perex@perex.cz \
--cc=rusty@rustcorp.com.au \
--cc=sandeen@redhat.com \
--cc=snitzer@redhat.com \
--cc=stoyboyker@gmail.com \
--cc=tglx@linutronix.de \
--cc=tiwai@suse.de \
--cc=viro@zeniv.linux.org.uk \
--cc=wangcong@zeuux.org \
--cc=wein@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox