From: Theodore Tso <tytso@mit.edu>
To: Eric Sandeen <sandeen@redhat.com>
Cc: ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] libext2fs: don't swap extent-based journal backup on read
Date: Thu, 12 Nov 2009 22:45:19 -0500 [thread overview]
Message-ID: <20091113034519.GA11891@mit.edu> (raw)
In-Reply-To: <4AF9D0F8.6020609@redhat.com>
On Tue, Nov 10, 2009 at 02:45:44PM -0600, Eric Sandeen wrote:
> The f_illitable_flexbg test was failing on ppc, because
> e2fsck_move_ext3_journal is doing a direct memcmp of i_block with
> s_jnl_blocks, and failing.
>
> This is because we don't swap extent data on read from disk; rather
> we do it when we access the extents. However, ext2fs_swap_super
> was swapping s_jnl_blocks unconditionally, so these didn't match.
>
> Looks like we need to treat s_jnl_blocks the same as i_block, and
> swap it on access, not on read. Except for the last i_size bit...
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Applied to the maint branch, thanks.
- Ted
prev parent reply other threads:[~2009-11-13 3:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-10 20:45 [PATCH] libext2fs: don't swap extent-based journal backup on read Eric Sandeen
2009-11-10 23:14 ` Andreas Dilger
2009-11-13 3:45 ` Theodore Tso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091113034519.GA11891@mit.edu \
--to=tytso@mit.edu \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).