From: Jan Kara <jack@suse.cz>
To: linux-ext4@vger.kernel.org
Cc: sandeen@redhat.com, tytso@mit.edu
Subject: norecovery option for ext3
Date: Fri, 20 Nov 2009 13:24:03 +0100 [thread overview]
Message-ID: <20091120122403.GD15422@duck.suse.cz> (raw)
Hi,
I've tried to test noload/norecovery option of ext3 and I've found it
simply does not work. The filesystem does not even mount. There are two
problems:
1) the code checking for NOLOAD in ext3_fill_super is simply wrong
and ends up failing the mount whenever NOLOAD is set with a message
"ext3: No journal on filesystem on <dev>"
2) if one fixes the check, we end up oopsing a few lines below when
calling journal_check_available_features() with journal == NULL.
Given that nobody used the option (OK, some googling shows that somebody
tried to use it in *2.4.9* kernel and it didn't work even there - Stephen
Tweedie comments that it's an obsolete option meant for use during fs
development) and seeing how badly corrupted the filesystem is when you
don't replay the journal, I'd just remove the option. Any opinions?
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
next reply other threads:[~2009-11-20 12:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-20 12:24 Jan Kara [this message]
2009-11-20 15:46 ` norecovery option for ext3 Eric Sandeen
2009-11-20 17:41 ` Andreas Dilger
2009-11-20 17:56 ` Eric Sandeen
2009-11-20 20:54 ` Jan Kara
-- strict thread matches above, loose matches on Subject: below --
2009-11-23 7:26 Alexey Fisher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091120122403.GD15422@duck.suse.cz \
--to=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox