From: tytso@mit.edu
To: Josef Bacik <josef@redhat.com>
Cc: linux-ext4@vger.kernel.org, sandeen@redhat.com
Subject: Re: [PATCH] Ext4: wait for log to commit when putting super V2.
Date: Tue, 8 Dec 2009 22:10:54 -0500 [thread overview]
Message-ID: <20091209031054.GY27692@thunk.org> (raw)
In-Reply-To: <20091207210044.GD8558@localhost.localdomain>
On Mon, Dec 07, 2009 at 04:00:44PM -0500, Josef Bacik wrote:
> Update:
> -Instead of adding new logic to wait for the journal to commit, just move the
> cleanup code below the journal destruction which does the same thing. Thanks to
> Eric Sandeen for the suggestion.
>
> There is a problem where a transaction will be committing while we're unmounting
> the filesystem and you will get a panic because EXT4_SB(sb)->s_group_info has
> been kfree'ed in ext4_put_super. The commit code does the callback for the
> mballoc stuff to release free'ed blocks in the transaction and panic's trying to
> access s_group_info. The fix is to wait for the transaction to finish
> committing before we start cleaning up the mballoc stuff. This patch hasn't
> been tested yet, but its an obvious fix.
Added to the ext4 patch queue, thanks.
- Ted
prev parent reply other threads:[~2009-12-09 3:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-07 21:00 [PATCH] Ext4: wait for log to commit when putting super V2 Josef Bacik
2009-12-09 3:10 ` tytso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091209031054.GY27692@thunk.org \
--to=tytso@mit.edu \
--cc=josef@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).