From: Jan Kara <jack@suse.cz>
To: Dmitry Monakhov <dmonakhov@openvz.org>
Cc: linux-ext4@vger.kernel.org, aneesh.kumar@linux.vnet.ibm.com,
jack@suse.cz, cmm@us.ibm.com, linux-fsdevel@vger.kernel.org,
Al Viro <viro@ZenIV.linux.org.uk>
Subject: Re: [PATCH 1/3] [RFC] vfs: add generic reserved space management interface
Date: Wed, 9 Dec 2009 12:08:36 +0100 [thread overview]
Message-ID: <20091209110836.GE4863@quack.suse.de> (raw)
In-Reply-To: <1260324686-15863-1-git-send-email-dmonakhov@openvz.org>
On Wed 09-12-09 05:11:24, Dmitry Monakhov wrote:
> Add new field "i_rsv_blocks" to generic inode. This value is
> managed similar to i_blocks, i_bytes fileds (protected by i_lock).
> This generic interface will be used by generic quota code similar
> to i_blocks.
I guess some people won't like bloating the VFS inode. It personally
makes my "quota" life easier but not that many filesystems need this
(currently I'm aware of only ext4) so their complaints are reasonable...
If we would eventually decide to go this way, I'd account reserved
space in bytes - quota is really accounted in bytes (as some filesystems
need this).
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
next prev parent reply other threads:[~2009-12-09 11:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-09 2:11 [PATCH 1/3] [RFC] vfs: add generic reserved space management interface Dmitry Monakhov
2009-12-09 2:11 ` [PATCH 2/3] quota: convert to generic reserved space management Dmitry Monakhov
2009-12-09 2:11 ` [PATCH 3/3] ext4: Convert to generic reserved quota's " Dmitry Monakhov
2009-12-10 0:16 ` Mingming
2009-12-10 0:19 ` [PATCH 2/3] quota: convert to generic reserved " Mingming
2009-12-10 1:13 ` Dmitry Monakhov
2009-12-09 10:45 ` [PATCH 1/3] [RFC] vfs: add generic reserved space management interface Christoph Hellwig
2009-12-09 14:24 ` Dmitry Monakhov
2009-12-09 11:08 ` Jan Kara [this message]
2009-12-09 14:51 ` Dmitry Monakhov
2009-12-09 17:00 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091209110836.GE4863@quack.suse.de \
--to=jack@suse.cz \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=cmm@us.ibm.com \
--cc=dmonakhov@openvz.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).