From: Matthew Wilcox <matthew@wil.cx>
To: Dmitry Monakhov <dmonakhov@openvz.org>
Cc: Jan Kara <jack@suse.cz>,
linux-ext4@vger.kernel.org, aneesh.kumar@linux.vnet.ibm.com,
cmm@us.ibm.com, linux-fsdevel@vger.kernel.org,
Al Viro <viro@ZenIV.linux.org.uk>
Subject: Re: [PATCH 1/3] [RFC] vfs: add generic reserved space management interface
Date: Wed, 9 Dec 2009 10:00:19 -0700 [thread overview]
Message-ID: <20091209170019.GA7246@parisc-linux.org> (raw)
In-Reply-To: <873a3kqjyy.fsf@openvz.org>
On Wed, Dec 09, 2009 at 05:51:17PM +0300, Dmitry Monakhov wrote:
> >From other point of view, we may change inode structure like this:
> struct quota_ptr
> {
> struct dquot *dquot[MAXQUOTAS];
> };
> struct quota_rsv_ptr
> {
> struct dquot *dquot[MAXQUOTAS];
> qsize_t reservation;
> };
> struct inode {
> ....
> #ifdef CONFIG_QUOTA
> union {
> struct quota_ptr i_dquot;
> struct quota_rsv_ptr i_dquot_rsv;
> };
> #endif
> ....
> };
What's wrong with:
#ifdef CONFIG_QUOTA
union {
struct dquot *i_dquot[MAXQUOTAS];
struct quota_rsv_ptr i_dquot_rsv;
};
#endif
voila, no changes needed.
--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
prev parent reply other threads:[~2009-12-09 17:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-09 2:11 [PATCH 1/3] [RFC] vfs: add generic reserved space management interface Dmitry Monakhov
2009-12-09 2:11 ` [PATCH 2/3] quota: convert to generic reserved space management Dmitry Monakhov
2009-12-09 2:11 ` [PATCH 3/3] ext4: Convert to generic reserved quota's " Dmitry Monakhov
2009-12-10 0:16 ` Mingming
2009-12-10 0:19 ` [PATCH 2/3] quota: convert to generic reserved " Mingming
2009-12-10 1:13 ` Dmitry Monakhov
2009-12-09 10:45 ` [PATCH 1/3] [RFC] vfs: add generic reserved space management interface Christoph Hellwig
2009-12-09 14:24 ` Dmitry Monakhov
2009-12-09 11:08 ` Jan Kara
2009-12-09 14:51 ` Dmitry Monakhov
2009-12-09 17:00 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091209170019.GA7246@parisc-linux.org \
--to=matthew@wil.cx \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=cmm@us.ibm.com \
--cc=dmonakhov@openvz.org \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).