From: tytso@mit.edu
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: Eric Sandeen <sandeen@redhat.com>,
Richard Kennedy <richard@rsk.demon.co.uk>,
adilger@sun.com, linux-ext4@vger.kernel.org,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ext4: return correct wbc.nr_to_write in ext4_da_writepages
Date: Fri, 25 Dec 2009 15:10:48 -0500 [thread overview]
Message-ID: <20091225201048.GF32757@thunk.org> (raw)
In-Reply-To: <20091217173232.GA2950@skywalker.linux.vnet.ibm.com>
On Thu, Dec 17, 2009 at 11:02:32PM +0530, Aneesh Kumar K.V wrote:
> On Thu, Dec 17, 2009 at 09:40:25AM -0600, Eric Sandeen wrote:
> > Richard Kennedy wrote:
> > > ext4: always re-base nr_to_write in ext4_da_writepages
> > >
> > > When ext4_da_writepages increases the nr_to_write in writeback_control
> > > then it must always re-base the return value.
> > >
> > > Without this change, when wb_writeback calculates how many pages were
> > > actually written it can get a negative value and loop more times than
> > > necessary. In tests I have seen nearly all the dirty pages pushed out to
> > > writeback due to this issue.
> > >
> > > Signed-off-by: Richard Kennedy <richard@rsk.demon.co.uk>
Added to the ext4 patch queue, thanks.
- Ted
prev parent reply other threads:[~2009-12-25 20:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-17 15:17 [PATCH] ext4: return correct wbc.nr_to_write in ext4_da_writepages Richard Kennedy
2009-12-17 15:40 ` Eric Sandeen
2009-12-17 15:58 ` Richard Kennedy
2009-12-17 17:32 ` Aneesh Kumar K.V
2009-12-25 20:10 ` tytso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091225201048.GF32757@thunk.org \
--to=tytso@mit.edu \
--cc=adilger@sun.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=richard@rsk.demon.co.uk \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).