[PATCH] jbd: jbd-debug and jbd2-debug should be writable.

[PATCH] jbd: jbd-debug and jbd2-debug should be writable.

[Yin, Kangkai]

Hi,

Re-send since seems my mail was dropped by vger, because of my wrong
envelope_from..

----
I was trying to enable the jbd debug option, and found that jbd-debug
in debugfs is read-only, shouldn't that be writable?

Found in both .31 stable kernel and .32 one.

Thanks,
Kangkai

>From 492ec0453ca3458c68deaa6e308ca01acc0eca1f Mon Sep 17 00:00:00 2001
From: Yin Kangkai <kangkai.yin@intel.com>
Date: Thu, 3 Dec 2009 18:01:38 +0800
Subject: [PATCH] jbd: jbd-debug and jbd2-debug should be writable.

jbd-debug and jbd2-debug is currently read-only (S_IRUGO), which is not
correct. Make it writable so that we can start debuging.

Signed-off-by: Yin Kangkai <kangkai.yin@intel.com>
---
 fs/jbd/journal.c  |    2 +-
 fs/jbd2/journal.c |    3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/fs/jbd/journal.c b/fs/jbd/journal.c
index 4160afa..bd224ee 100644
--- a/fs/jbd/journal.c
+++ b/fs/jbd/journal.c
@@ -1913,7 +1913,7 @@ static void __init jbd_create_debugfs_entry(void)
 {
 	jbd_debugfs_dir = debugfs_create_dir("jbd", NULL);
 	if (jbd_debugfs_dir)
-		jbd_debug = debugfs_create_u8("jbd-debug", S_IRUGO,
+		jbd_debug = debugfs_create_u8("jbd-debug", S_IRUGO | S_IWUSR,
 					       jbd_debugfs_dir,
 					       &journal_enable_debug);
 }
diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c
index fed8538..3c41c5a 100644
--- a/fs/jbd2/journal.c
+++ b/fs/jbd2/journal.c
@@ -2103,7 +2103,8 @@ static void __init jbd2_create_debugfs_entry(void)
 {
 	jbd2_debugfs_dir = debugfs_create_dir("jbd2", NULL);
 	if (jbd2_debugfs_dir)
-		jbd2_debug = debugfs_create_u8(JBD2_DEBUG_NAME, S_IRUGO,
+		jbd2_debug = debugfs_create_u8(JBD2_DEBUG_NAME,
+					       S_IRUGO | S_IWUSR,
 					       jbd2_debugfs_dir,
 					       &jbd2_journal_enable_debug);
 }
-- 
1.6.5

Re: [PATCH] jbd: jbd-debug and jbd2-debug should be writable.

[Aneesh Kumar K.V]

On Fri, Dec 04, 2009 at 11:17:35AM +0800, Yin, Kangkai wrote:
> Hi,
> 
> Re-send since seems my mail was dropped by vger, because of my wrong
> envelope_from..
> 
> ----
> I was trying to enable the jbd debug option, and found that jbd-debug
> in debugfs is read-only, shouldn't that be writable?
> 
> Found in both .31 stable kernel and .32 one.
> 
> Thanks,
> Kangkai
> 
> From 492ec0453ca3458c68deaa6e308ca01acc0eca1f Mon Sep 17 00:00:00 2001
> From: Yin Kangkai <kangkai.yin@intel.com>
> Date: Thu, 3 Dec 2009 18:01:38 +0800
> Subject: [PATCH] jbd: jbd-debug and jbd2-debug should be writable.
> 
> jbd-debug and jbd2-debug is currently read-only (S_IRUGO), which is not
> correct. Make it writable so that we can start debuging.
> 
> Signed-off-by: Yin Kangkai <kangkai.yin@intel.com>

Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>

> ---
>  fs/jbd/journal.c  |    2 +-
>  fs/jbd2/journal.c |    3 ++-
>  2 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/jbd/journal.c b/fs/jbd/journal.c
> index 4160afa..bd224ee 100644
> --- a/fs/jbd/journal.c
> +++ b/fs/jbd/journal.c
> @@ -1913,7 +1913,7 @@ static void __init jbd_create_debugfs_entry(void)
>  {
>  	jbd_debugfs_dir = debugfs_create_dir("jbd", NULL);
>  	if (jbd_debugfs_dir)
> -		jbd_debug = debugfs_create_u8("jbd-debug", S_IRUGO,
> +		jbd_debug = debugfs_create_u8("jbd-debug", S_IRUGO | S_IWUSR,
>  					       jbd_debugfs_dir,
>  					       &journal_enable_debug);
>  }
> diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c
> index fed8538..3c41c5a 100644
> --- a/fs/jbd2/journal.c
> +++ b/fs/jbd2/journal.c
> @@ -2103,7 +2103,8 @@ static void __init jbd2_create_debugfs_entry(void)
>  {
>  	jbd2_debugfs_dir = debugfs_create_dir("jbd2", NULL);
>  	if (jbd2_debugfs_dir)
> -		jbd2_debug = debugfs_create_u8(JBD2_DEBUG_NAME, S_IRUGO,
> +		jbd2_debug = debugfs_create_u8(JBD2_DEBUG_NAME,
> +					       S_IRUGO | S_IWUSR,
>  					       jbd2_debugfs_dir,
>  					       &jbd2_journal_enable_debug);
>  }
> -- 
> 1.6.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] jbd: jbd-debug and jbd2-debug should be writable.

[tytso]

The ext4 portion has been added to the ext4 patch queue.

Jan, you want to add this to the ext3 tree?

					- Ted

jbd: /sys/kernel/debug/jbd/jbd-debug should be writable.

From: "Yin, Kangkai" <kangkai.yin@intel.com>

Make this sysfs file writeable so we can enable debugging without
needing to reboot and futzing with boot command-line option.

Signed-off-by: Yin Kangkai <kangkai.yin@intel.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
---
 fs/jbd/journal.c  |    2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/fs/jbd/journal.c b/fs/jbd/journal.c
index 4160afa..bd224ee 100644
--- a/fs/jbd/journal.c
+++ b/fs/jbd/journal.c
@@ -1913,7 +1913,7 @@ static void __init jbd_create_debugfs_entry(void)
 {
 	jbd_debugfs_dir = debugfs_create_dir("jbd", NULL);
 	if (jbd_debugfs_dir)
-		jbd_debug = debugfs_create_u8("jbd-debug", S_IRUGO,
+		jbd_debug = debugfs_create_u8("jbd-debug", S_IRUGO | S_IWUSR,
 					       jbd_debugfs_dir,
 					       &journal_enable_debug);
 }

Re: [PATCH] jbd: jbd-debug and jbd2-debug should be writable.

[Jan Kara]

On Fri 25-12-09 15:48:59, tytso@mit.edu wrote:
> The ext4 portion has been added to the ext4 patch queue.
> 
> Jan, you want to add this to the ext3 tree?
  Thanks for the notification. Actually, I've already sent the original
patch to Linus and that was for both jbd and jbd2. The patch was so trivial
I thought it's not worth splitting it up. I'm sorry if it caused any
trouble to you.

									Honza
-- 
Jan Kara <jack@suse.cz>
SUSE Labs, CR

Re: [PATCH] jbd: jbd-debug and jbd2-debug should be writable.

[tytso]

On Mon, Jan 04, 2010 at 11:26:14PM +0100, Jan Kara wrote:
> On Fri 25-12-09 15:48:59, tytso@mit.edu wrote:
> > The ext4 portion has been added to the ext4 patch queue.
> > 
> > Jan, you want to add this to the ext3 tree?
>   Thanks for the notification. Actually, I've already sent the original
> patch to Linus and that was for both jbd and jbd2. The patch was so trivial
> I thought it's not worth splitting it up. I'm sorry if it caused any
> trouble to you.

No worries, I hadn't realized it had already been sent up to Linus.

   	      	     	      	     - Ted