From: Wu Fengguang <fengguang.wu@intel.com>
To: Jan Kara <jack@suse.cz>
Cc: "linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>,
"tytso@mit.edu" <tytso@mit.edu>
Subject: Re: ext4_da_block_invalidatepages() question
Date: Wed, 27 Jan 2010 09:53:39 +0800 [thread overview]
Message-ID: <20100127015339.GA8132@localhost> (raw)
In-Reply-To: <20100126153222.GI3187@quack.suse.cz>
On Tue, Jan 26, 2010 at 08:32:22AM -0700, Jan Kara wrote:
> @@ -2127,17 +2127,16 @@ static void ext4_da_block_invalidatepages(struct mpage_da_data *mpd,
> break;
> for (i = 0; i < nr_pages; i++) {
> struct page *page = pvec.pages[i];
> - index = page->index;
> - if (index > end)
> + if (page->index > end)
> break;
> - index++;
> -
> BUG_ON(!PageLocked(page));
> BUG_ON(PageWriteback(page));
> block_invalidatepage(page, 0);
> ClearPageUptodate(page);
> unlock_page(page);
> }
> + index = pvec.pages[nr_pages - 1]->index + 1;
> + pagevec_release(&pvec);
> }
> return;
> }
The patch includes a cleanup and a bug fix, both looks OK to me.
But if we can split it, the bug fix would be good candidate for
the stable kernel?
Thanks,
Fengguang
next prev parent reply other threads:[~2010-01-27 2:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-26 13:36 ext4_da_block_invalidatepages() question Wu Fengguang
2010-01-26 15:32 ` Jan Kara
2010-01-27 1:53 ` Wu Fengguang [this message]
2010-01-27 12:25 ` Jan Kara
2010-01-27 12:34 ` Wu Fengguang
2010-02-09 15:39 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100127015339.GA8132@localhost \
--to=fengguang.wu@intel.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).