From: Josef Bacik <josef@redhat.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: ext4 development <linux-ext4@vger.kernel.org>,
Giel de Nijs <giel@vectorwise.com>
Subject: Re: [PATCH V2] fix type of "offset" in ext4_io_end
Date: Fri, 29 Jan 2010 15:32:04 -0500 [thread overview]
Message-ID: <20100129203204.GE2209@localhost.localdomain> (raw)
In-Reply-To: <4B6344E7.9050503@redhat.com>
On Fri, Jan 29, 2010 at 02:28:23PM -0600, Eric Sandeen wrote:
> The "offset" member in ext4_io_end holds bytes, not
> blocks, so ext4_lblk_t is wrong - and too small (u32)
>
> This caused the testcase "Possible ext4 data corruption
> with large files and async I/O" sent by Giel to fail when it
> wrapped around to 0.
>
> Also fix up the type of arguments to
> ext4_convert_unwritten_extents(), it gets ssize_t from
> ext4_end_aio_dio_nolock() and ext4_ext_direct_IO()
>
> Reported-by: Giel de Nijs <giel@vectorwise.com>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
>
> V2: Post-review Josef spotted another size_t in ext4_end_aio_dio_nolock()
>
Reviewed-by: Josef Back <josef@redhat.com>
probably should have said something before replying to the last email :).
Thanks,
Josef
next prev parent reply other threads:[~2010-01-29 20:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-29 18:24 [PATCH] fix type of "offset" in ext4_io_end Eric Sandeen
2010-01-29 20:21 ` Josef Bacik
2010-01-29 20:28 ` [PATCH V2] " Eric Sandeen
2010-01-29 20:32 ` Josef Bacik [this message]
2010-01-30 17:34 ` tytso
2010-01-30 18:33 ` Eric Sandeen
2010-02-05 13:37 ` tytso
2010-02-05 15:50 ` Eric Sandeen
2010-02-05 16:34 ` tytso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100129203204.GE2209@localhost.localdomain \
--to=josef@redhat.com \
--cc=giel@vectorwise.com \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).