From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: xfs-oss <xfs@oss.sgi.com>, ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] xfstests: 223 - test file alignment on stripe geometry
Date: Sat, 30 Jan 2010 05:52:36 -0500 [thread overview]
Message-ID: <20100130105236.GA18286@infradead.org> (raw)
In-Reply-To: <4B621529.20708@sandeen.net>
> +# real QA test starts here
> +_supported_fs xfs ext4
I'd make this generic and just do the notrun in scratch_mkfs_geom for
non-supported filesystems.
> +scratch_mkfs_geom()
> +{
And I'd throw this one into common.rc.
> +=== Testing size 1073745920 falloc on 128k stripe ===
> +SCRATCH_MNT/file-1073745920-falloc: well-aligned
> diff --git a/common.rc b/common.rc
> index 6424871..97513cc 100644
> --- a/common.rc
> +++ b/common.rc
> @@ -292,7 +292,7 @@ _scratch_mkfs()
> $MKFS_UDF_PROG $MKFS_OPTIONS $* $SCRATCH_DEV > /dev/null
> ;;
> *)
> - /sbin/mkfs -t $FSTYP -- $MKFS_OPTIONS $* $SCRATCH_DEV > /dev/null
> + /sbin/mkfs -t $FSTYP -- $MKFS_OPTIONS $* $SCRATCH_DEV
Hmm, doesn't this change break other testcase? Anyway needs some
rationale in the changelog.
> index 0000000..fa005b2
> --- /dev/null
> +++ b/src/fibmap.c
This is a bit misnamed as it's not a generic fibmap tool but rather
a specific tool comparing the bmap to the sunit alignment.
next prev parent reply other threads:[~2010-01-30 10:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-28 22:52 [PATCH] xfstests: 223 - test file alignment on stripe geometry Eric Sandeen
2010-01-30 10:52 ` Christoph Hellwig [this message]
2010-01-30 16:13 ` Eric Sandeen
2010-01-30 19:09 ` Christoph Hellwig
2010-02-02 23:28 ` [PATCH V2] " Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100130105236.GA18286@infradead.org \
--to=hch@infradead.org \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).