From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Christoph Hellwig <hch@infradead.org>, xfs-oss <xfs@oss.sgi.com>,
ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] xfstests: 223 - test file alignment on stripe geometry
Date: Sat, 30 Jan 2010 14:09:35 -0500 [thread overview]
Message-ID: <20100130190935.GB10181@infradead.org> (raw)
In-Reply-To: <4B645AB9.8050508@sandeen.net>
> didn't break anything for me; I wanted to be able to see the mkfs
> results w/ geometry, is all. Will re-double-check but it was fine AFAIK.
Yeah, doesn't seem to cause any problems with a full xfsqa run for me.
> > This is a bit misnamed as it's not a generic fibmap tool but rather
> > a specific tool comparing the bmap to the sunit alignment.
> >
>
> good point .. how about making it more generic, something like:
>
> fibmap -o <file offset> -l <length> -s <stripe alignment> <filename>
>
> hmm though I hate to reqwrite filefrag ... :)
>
> I suppose something like this could go into xfs_io as well, but that
> makes this test unavailable to the masses until another release, at least.
I'd just leave it as is but call it t_stripealign or similar.
next prev parent reply other threads:[~2010-01-30 19:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-28 22:52 [PATCH] xfstests: 223 - test file alignment on stripe geometry Eric Sandeen
2010-01-30 10:52 ` Christoph Hellwig
2010-01-30 16:13 ` Eric Sandeen
2010-01-30 19:09 ` Christoph Hellwig [this message]
2010-02-02 23:28 ` [PATCH V2] " Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100130190935.GB10181@infradead.org \
--to=hch@infradead.org \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).