From: tytso@mit.edu
To: Eric Sandeen <sandeen@redhat.com>
Cc: ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] mke2fs: fix up topo complaints on regular files
Date: Sat, 6 Feb 2010 08:01:26 -0500 [thread overview]
Message-ID: <20100206130126.GB321@thunk.org> (raw)
In-Reply-To: <4B5BC395.2050805@redhat.com>
On Sat, Jan 23, 2010 at 09:50:45PM -0600, Eric Sandeen wrote:
> mkfsing a plain file would lead to a warning about being unable
> to determine geometry; we should just skip the topology-getting
> if we see that we have a regular file.
>
> This was breaking "make check" but I had missed it since I
> inadvertently stopped running the checks during the Fedora
> RPM build.
>
> Also, add a newline to the warning.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Thanks, applied.
- Ted
prev parent reply other threads:[~2010-02-06 13:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-24 3:50 [PATCH] mke2fs: fix up topo complaints on regular files Eric Sandeen
2010-02-06 13:01 ` tytso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100206130126.GB321@thunk.org \
--to=tytso@mit.edu \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).