From: Andrew Morton <akpm@linux-foundation.org>
To: tytso@mit.edu
Cc: Jan Kara <jack@suse.cz>,
Christoph Egger <siccegge@stud.informatik.uni-erlangen.de>,
linux-kernel@vger.kernel.org,
Kazuo Moriwaka <moriwaka@redhat.com>,
H Hartley Sweeten <hsweeten@visionengravers.com>,
Joel Becker <joel.becker@oracle.com>,
linux-ext4@vger.kernel.org, vamos@i4.informatik.uni-erlangen.de
Subject: Re: [PATCH] obsolete config in kernel source (BUFFER_DEBUG)
Date: Mon, 8 Feb 2010 10:58:28 -0800 [thread overview]
Message-ID: <20100208105828.1136310a.akpm@linux-foundation.org> (raw)
In-Reply-To: <20100208155031.GK4494@thunk.org>
On Mon, 8 Feb 2010 10:50:31 -0500 tytso@mit.edu wrote:
> I don't have an objection with removing this, but does anyone have the
> latest version of akpm's buffer debugging patches?
My version is datestamped four years ago :( It normally forward-ports
fairly easily.
> I *think* what happened is that akpm forward ported the removed buffer
> debugging patches, or maybe rewrote it from scratch, but for whatever
> reason they never made back into mainline. Maybe they were too ugly
> to live in mainline, but they have been really handy on occasion.
I think Eric Sandeen might have a fresher version. Nowadays it should
be done with the tracing infrastructure, I guess. Although that
infrastructure may not be able to do this - the ext3 debug patch
recorded an LRU array of the below structs within every buffer_head.
The various BUFFER_TRACE macros would emit a new record into the tail of the
target bh's b[] ring.
struct buffer_history {
struct buffer_history_item {
char *function;
char *info;
unsigned long b_state;
unsigned b_list:3;
unsigned b_jlist:4;
unsigned pg_dirty:1;
unsigned cpu:3;
unsigned b_count:8;
unsigned long b_blocknr; /* For src != dest */
#if defined(CONFIG_JBD) || defined(CONFIG_JBD_MODULE)
unsigned b_jcount:4;
unsigned b_jbd:1;
unsigned b_transaction:1;
unsigned b_next_transaction:1;
unsigned b_cp_transaction:1;
unsigned b_trans_is_running:1;
unsigned b_trans_is_committing:1;
void *b_frozen_data;
void *b_committed_data;
#endif
} b[BUFFER_HISTORY_SIZE];
unsigned long b_history_head; /* Next place to write */
unsigned long b_history_tail; /* Oldest valid entry */
};
next prev parent reply other threads:[~2010-02-08 18:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-05 13:13 [PATCH] obsolete config in kernel source (BUFFER_DEBUG) Christoph Egger
2010-02-08 13:56 ` Jan Kara
2010-02-08 15:50 ` tytso
2010-02-08 18:58 ` Andrew Morton [this message]
2010-02-08 19:02 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100208105828.1136310a.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=hsweeten@visionengravers.com \
--cc=jack@suse.cz \
--cc=joel.becker@oracle.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=moriwaka@redhat.com \
--cc=siccegge@stud.informatik.uni-erlangen.de \
--cc=tytso@mit.edu \
--cc=vamos@i4.informatik.uni-erlangen.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).