From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@bugzilla.kernel.org Subject: [Bug 15231] kernel BUG at fs/ext4/inode.c:1852! Date: Tue, 9 Feb 2010 18:27:44 GMT Message-ID: <201002091827.o19IRiC5018525@demeter.kernel.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" To: linux-ext4@vger.kernel.org Return-path: Received: from demeter.kernel.org ([140.211.167.39]:41477 "EHLO demeter.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751265Ab0BIS1p (ORCPT ); Tue, 9 Feb 2010 13:27:45 -0500 Received: from demeter.kernel.org (localhost.localdomain [127.0.0.1]) by demeter.kernel.org (8.14.3/8.14.3) with ESMTP id o19IRi7l018531 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Tue, 9 Feb 2010 18:27:45 GMT In-Reply-To: Sender: linux-ext4-owner@vger.kernel.org List-ID: http://bugzilla.kernel.org/show_bug.cgi?id=15231 --- Comment #8 from Theodore Tso 2010-02-09 18:27:22 --- Well, the BUG_ON getting tripped as reported in comment #1 in this bug is: BUG_ON(mdblocks < EXT4_I(inode)->i_reserved_meta_blocks); ... and the commit 39bc680a does mess with how i_reserved_meta_blocks is calculated. @@ -1836,10 +1834,11 @@ repeat: } return -ENOSPC; } + spin_lock(&EXT4_I(inode)->i_block_reservation_lock); EXT4_I(inode)->i_reserved_data_blocks += nrblocks; - EXT4_I(inode)->i_reserved_meta_blocks = mdblocks;