From: tytso@mit.edu
To: Roel Kluin <roel.kluin@gmail.com>
Cc: Andreas Dilger <adilger@sun.com>,
linux-ext4@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ext4: ext4_xattr_ibody_set() error ignored in ext4_expand_extra_isize_ea()
Date: Mon, 15 Feb 2010 14:28:49 -0500 [thread overview]
Message-ID: <20100215192849.GM5337@thunk.org> (raw)
In-Reply-To: <4B6AF1AF.3010008@gmail.com>
On Thu, Feb 04, 2010 at 05:11:27PM +0100, Roel Kluin wrote:
> The error handling was missing.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> Is this needed?
Yep, it's added, thanks. I'm not entirely right the error handling is
completely correct in this function; in particular, if we fail after
this point in the function, and we've already changed the status of
EXT4_STATE_XATTR flag, but then we fail due to some error (maybe an
I/O error), it's not clear the cleanup section is properly unwinding
all of the side effects made so far in this function.
Still, adding the error check clearly makes the code better than it
was before, so I've added it to the ext4 patch queue.
- Ted
prev parent reply other threads:[~2010-02-15 19:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-04 16:11 [PATCH] ext4: ext4_xattr_ibody_set() error ignored in ext4_expand_extra_isize_ea() Roel Kluin
2010-02-15 19:28 ` tytso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100215192849.GM5337@thunk.org \
--to=tytso@mit.edu \
--cc=adilger@sun.com \
--cc=akpm@linux-foundation.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).